Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Covers not visible in playlist (subsonic provider) #3215

Open
1 task done
de666 opened this issue Nov 23, 2024 · 2 comments · May be fixed by music-assistant/server#1796
Open
1 task done

Covers not visible in playlist (subsonic provider) #3215

de666 opened this issue Nov 23, 2024 · 2 comments · May be fixed by music-assistant/server#1796
Assignees
Labels
bug Something isn't working Subsonic

Comments

@de666
Copy link

de666 commented Nov 23, 2024

What version of Music Assistant has the issue?

2.3.3

What version of the Home Assistant Integration have you got installed?

2024.11.4

Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

  • Yes

The problem

Opening a playlist from subsonic provider results in not showing any cover art in the track list, only the main playlist cover art is shown.
This happens only for playlists, not for album track list or album list.

How to reproduce

using subsonic provider open a playlist, no cover art displayed for any track in the playlist

Music Providers

Subsonic

Player Providers

Any

Full log output

No response

Additional information

playlist view
playlist_view
tracks from an album view (correct), same as album list
album_view

Just for the record, in Symphonium android app, cover arts are correctly displayed when opening any playlist.

What version of Home Assistant Core are your running

2024.11.3

What type of installation are you running?

Home Assistant OS

On what type of hardware are you running?

Generic x86-64 (e.g. Intel NUC)

@de666 de666 added the triage label Nov 23, 2024
@khers
Copy link

khers commented Nov 23, 2024

I see this as well, the tracks in a playlist do not show the album cover art, I am not sure that album covers are associated with tracks but if they are supposed to be, I can make that change in the provider.

@OzGav OzGav added bug Something isn't working and removed triage labels Nov 23, 2024
@OzGav OzGav added the Subsonic label Nov 23, 2024
@de666
Copy link
Author

de666 commented Nov 25, 2024

I am not sure that album covers are associated with tracks but if they are supposed to be, I can make that change in the provider.

The other providers show the track cover so I think subsonic provider should behave the same way.

khers added a commit to khers/server that referenced this issue Nov 29, 2024
In order to display album art in the playlist view, we need to have an
album associated with each track. Mappings do not seem to be sufficient
here. Allow any caller of _parse_track() to optionally provide an Album
that should be used for this track and ensure that the playlist display
queries that album and uses it.

Fixes: music-assistant/hass-music-assistant#3215

Signed-off-by: Eric B Munson <[email protected]>
khers added a commit to khers/server that referenced this issue Nov 29, 2024
In order to display album art in the playlist view, we need to have an
album associated with each track. Mappings do not seem to be sufficient
here. Allow any caller of _parse_track() to optionally provide an Album
that should be used for this track and ensure that the playlist display
queries that album and uses it.

Fixes: music-assistant/hass-music-assistant#3215

Signed-off-by: Eric B Munson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Subsonic
Projects
Status: NOW
Development

Successfully merging a pull request may close this issue.

3 participants