Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emote identifiers can be strings #240

Open
halzy opened this issue Dec 2, 2022 · 1 comment · May be fixed by #241
Open

Emote identifiers can be strings #240

halzy opened this issue Dec 2, 2022 · 1 comment · May be fixed by #241

Comments

@halzy
Copy link
Collaborator

halzy commented Dec 2, 2022

For example, with subscriber emotes the id is a string like: emotesv2_c9b440ae1089457fbec4bd83ce091b0a

Full Privmsg dump:

Privmsg {
    raw: "@badge-info=;badges=;client-nonce=6165e054a7a023fdc345cc99944d9090;color=#FF9CEE;display-name=GlitchButSmol;emote-only=1;emotes=emotesv2_c9b440ae1089457fbec4bd83ce091b0a:0-9/emotesv2_99e7ca82ee744cae9f54dced65ea4658:11-21/emotesv2_fb79a7ffecfc4ff89486317d0d8bd582:23-36;first-msg=0;flags=;id=d642db40-fddf-4c07-bc9d-43779f15dbdf;mod=0;returning-chatter=0;room-id=75244893;subscriber=0;tmi-sent-ts=1669989103046;turbo=0;user-id=403440621;user-type= :[email protected] PRIVMSG #mrhalzy :breade3Box icedkiSleep idlefaBlankies\r\n",
    tags: {
        "badge-info": "",
        "badges": "",
        "client-nonce": "6165e054a7a023fdc345cc99944d9090",
        "color": "#FF9CEE",
        "display-name": "GlitchButSmol",
        "emote-only": "1",
        "emotes": "emotesv2_c9b440ae1089457fbec4bd83ce091b0a:0-9/emotesv2_99e7ca82ee744cae9f54dced65ea4658:11-21/emotesv2_fb79a7ffecfc4ff89486317d0d8bd582:23-36",
        "first-msg": "0",
        "flags": "",
        "id": "d642db40-fddf-4c07-bc9d-43779f15dbdf",
        "mod": "0",
        "returning-chatter": "0",
        "room-id": "75244893",
        "subscriber": "0",
        "tmi-sent-ts": "1669989103046",
        "turbo": "0",
        "user-id": "403440621",
        "user-type": "",
    },
    name: "glitchbutsmol",
    channel: "#mrhalzy",
    data: "breade3Box icedkiSleep idlefaBlankies",
    ctcp: None,
}
@Emilgardis
Copy link
Collaborator

Emilgardis commented Dec 2, 2022

This is after emotes v2, with emotesv1 they didn't have this prefix. This was changed sometime in 2021, around august

Fixing this should be easy, I think it's ok to strip the emotesv2_ prefix since it was just a way for twitch to force irc clients to use the new v2 endpoint for images.

I retract this statement, it's ascii now :)

@Emilgardis Emilgardis linked a pull request Dec 2, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants