Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when pasting a note with a dynamic #25676

Closed
4 tasks done
mathesoncalum opened this issue Nov 28, 2024 · 2 comments · Fixed by #25686
Closed
4 tasks done

Crash when pasting a note with a dynamic #25676

mathesoncalum opened this issue Nov 28, 2024 · 2 comments · Fixed by #25686
Assignees
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression nightly Works correctly in the latest released version and is broken in the nightly builds

Comments

@mathesoncalum
Copy link
Contributor

Issue type

Crash or freeze

Description with steps to reproduce

  1. Copy a measure containing a note with a dynamic
  2. Paste it
  3. Undo
  4. Try to paste again to the same spot - MuseScore crashes

It appears we end up in an infinite loop inside Score::makeGap - call stack goes:

...
NotationActionController::pasteSelection
NotationInteraction::pasteSelection
Score::cmdPaste
Score::pasteStaff
Read410::pasteStaff
Score::makeGap
(infinite loop)

Supporting files, videos and screenshots

dynamiccrash.mov

What is the latest version of MuseScore Studio where this issue is present?

4.5 nightly

Regression

Yes, this works in the latest released version and is broken in the nightly builds

Operating system

Tested on macOS Sonoma 14.6.1

Additional context

4.4.4 seems to be fine, crash seems to be present in 4.5 only

Checklist

  • This report follows the guidelines for reporting bugs and issues
  • I have verified that this issue has not been logged before, by searching the issue tracker for similar issues
  • I have attached all requested files and information to this report
  • I have attempted to identify the root problem as concisely as possible, and have used minimal reproducible examples where possible
@muse-bot muse-bot added crash Issues involving a crash of MuseScore regression nightly Works correctly in the latest released version and is broken in the nightly builds labels Nov 28, 2024
@DmitryArefiev
Copy link
Contributor

The same on Windows 10 (4.5 nightly only)

@DmitryArefiev
Copy link
Contributor

Fixed in #25686

RomanPudashkin added a commit that referenced this issue Dec 2, 2024
Fix #25676: When pasting a dynamic, `undoAdd` a segment if it doesn't already exist
@github-project-automation github-project-automation bot moved this from In Progress to Done in MuseScore Studio 4.5 Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Issues involving a crash of MuseScore P0 Priority: Critical regression nightly Works correctly in the latest released version and is broken in the nightly builds
Projects
Status: Done
5 participants