Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to change image name from redsocks to munkyboy/redsocks in docker run command #4

Open
oveits opened this issue Dec 7, 2015 · 0 comments

Comments

@oveits
Copy link

oveits commented Dec 7, 2015

Hi munkyboy,
nice work! Thanks for sharing the image with us.

Just a minor suggestion from my side: I suggest that you change

docker run --net=host -e http_proxy=http://1.2.3.4:3128 redsocks

by

docker run --net=host -e http_proxy=http://1.2.3.4:3128 munkyboy/redsocks

(therwise the image will not be found.

Another change request on my side would be to exchange it by

docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 -e https_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks

or if you like it shorter:

docker run --net=host -e http_proxy=http://yourproxy.company.com:8080 munkyboy/redsocks

this would explain better, how the variable is used.

I found port 3128 a little bit confusing, since it looks so much alike the port 3129 used in https://github.com/jpetazzo/squid-in-a-can, which seems to be the local squid port they are using there, while in your docker run command, you need to specify the IP address or name plus port of the external http proxy.

Best Regards,
Oliver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant