Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonuses don't appear to function correctly #150

Open
ghost opened this issue Jul 16, 2015 · 2 comments
Open

Bonuses don't appear to function correctly #150

ghost opened this issue Jul 16, 2015 · 2 comments

Comments

@ghost
Copy link

ghost commented Jul 16, 2015

After applying a bonus multiplier of 25x to the server for 10 minutes, during which time I killed several different kinds of monsters, I didn't appear to detect any increase in the drop rate of either items or money (I'm not sure which one this is supposed to affect). Is this a misconfiguration? An error in syntax for the command? Or is it simply not applying the multiplier correctly? If I'm being stupid about it, feel free to call me out, I'd be rather interested in getting this working. Thanks for making a great plugin!

Command used: /ecoc setbonus 25 10min Testing

Version of EcoCreature: 0.3.0-SNAPSHOT-b458
Version of Spigot: git-Spigot-44c59bf-8f0f4ed (MC 1.8.7)

Debug Log reported the following messages:

[05:49:56] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.8
[05:49:56] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:49:56] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:49:56] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:49:56] [Server thread/INFO]: [ecoCreature] DropConfig: ===== START: gain calculation for Islid
[05:49:56] [Server thread/INFO]: [ecoCreature] GroupGain: Gain: 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] TimeGain: Gain: 0.8
[05:49:56] [Server thread/INFO]: [ecoCreature] EnvironmentGain: Gain: 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] BiomeGain: Gain: 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] WeatherGain: Gain: 0.75
[05:49:56] [Server thread/INFO]: [ecoCreature] WeaponGain: Gain: 1.5
[05:49:56] [Server thread/INFO]: [ecoCreature] RegionGain: Gain: 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:49:56] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:49:56] [Server thread/INFO]: [ecoCreature] CronGain: Gain: 1.0
[05:49:56] [Server thread/INFO]: [ecoCreature] DropConfig: ===== END: gain is 0.9000000000000001
[05:49:56] [Server thread/INFO]: [ecoCreature] MobArenaParty: Party size: 0
[05:49:56] [Server thread/INFO]: [ecoCreature] HeroesParty: Party size: 0
[05:49:56] [Server thread/INFO]: [ecoCreature] McMMOParty: Party size: 0
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== START: coin calculation for Skeleton
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount: 31.69552702320407
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: Gain: 0.9000000000000001
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount * gain: 28.525974320883666
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: Rounded decimal amount: 28.53
[05:49:56] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== END: amount is 28.53
[05:49:56] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton

[05:50:03] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.8
[05:50:03] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:50:03] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:50:03] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
[05:50:03] [Server thread/INFO]: [ecoCreature] DropConfig: ===== START: gain calculation for Islid
[05:50:03] [Server thread/INFO]: [ecoCreature] GroupGain: Gain: 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] TimeGain: Gain: 0.8
[05:50:03] [Server thread/INFO]: [ecoCreature] EnvironmentGain: Gain: 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] BiomeGain: Gain: 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] WeatherGain: Gain: 0.75
[05:50:03] [Server thread/INFO]: [ecoCreature] WeaponGain: Gain: 1.5
[05:50:03] [Server thread/INFO]: [ecoCreature] RegionGain: Gain: 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:50:03] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:50:03] [Server thread/INFO]: [ecoCreature] CronGain: Gain: 1.0
[05:50:03] [Server thread/INFO]: [ecoCreature] DropConfig: ===== END: gain is 0.9000000000000001
[05:50:03] [Server thread/INFO]: [ecoCreature] MobArenaParty: Party size: 0
[05:50:03] [Server thread/INFO]: [ecoCreature] HeroesParty: Party size: 0
[05:50:03] [Server thread/INFO]: [ecoCreature] McMMOParty: Party size: 0
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== START: coin calculation for Skeleton
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount: 26.06801380634129
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: Gain: 0.9000000000000001
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount * gain: 23.461212425707167
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: Rounded decimal amount: 23.46
[05:50:03] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== END: amount is 23.46
[05:50:03] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Skeleton
@ghost
Copy link
Author

ghost commented Jul 16, 2015

[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.93
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.9
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.05
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.25
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.02
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 0.25
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] AbstractChance: applying bonus multiplier 25.0 to 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] DropMetrics: Added metrics count for Zombie
[05:51:41] [Server thread/INFO]: [ecoCreature] DropConfig: ===== START: gain calculation for josln
[05:51:41] [Server thread/INFO]: [ecoCreature] GroupGain: Gain: 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] TimeGain: Gain: 0.8
[05:51:41] [Server thread/INFO]: [ecoCreature] EnvironmentGain: Gain: 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] BiomeGain: Gain: 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] WeatherGain: Gain: 0.75
[05:51:41] [Server thread/INFO]: [ecoCreature] WeaponGain: Gain: 0.5
[05:51:41] [Server thread/INFO]: [ecoCreature] RegionGain: Gain: 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:51:41] [Server thread/INFO]: [ecoCreature] CronGain: quartz jar not installed
[05:51:41] [Server thread/INFO]: [ecoCreature] CronGain: Gain: 1.0
[05:51:41] [Server thread/INFO]: [ecoCreature] DropConfig: ===== END: gain is 0.30000000000000004
[05:51:41] [Server thread/INFO]: [ecoCreature] MobArenaParty: Party size: 0
[05:51:41] [Server thread/INFO]: [ecoCreature] HeroesParty: Party size: 0
[05:51:41] [Server thread/INFO]: [ecoCreature] McMMOParty: Party size: 0
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== START: coin calculation for Zombie
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount: 26.777871122519027
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: Gain: 0.30000000000000004
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: Initial amount * gain: 8.033361336755709
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: Rounded decimal amount: 8.03
[05:51:41] [Server thread/INFO]: [ecoCreature] CoinDrop: ===== END: amount is 8.03
[05:51:41] [Server thread/INFO]: [ecoCreature] josln: &7You are awarded &6$8.03&7 for slaying a &5Zombie&7.

@mung3r
Copy link
Owner

mung3r commented Aug 17, 2015

Based on the debug logs, it looks like the bonus was applied correctly but then it gets cut down by that coindrop gain factor of 0.3.

Also, the bonus applies to drops and money.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mung3r