Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unexpected server disconnection due to SSL_ERROR_SYSCALL with e… #8

Conversation

botanegg
Copy link
Contributor

@botanegg botanegg commented Feb 12, 2023

…rrno == EAGAIN

Seems like the documentation recommends just repeating the request

UPD NOT_FULLY_closes #7

src/TLS.cpp Outdated Show resolved Hide resolved
…rrno == EAGAIN

Seems like the documentation recommends just repeating the request
@botanegg botanegg force-pushed the 7-closing-tcp-connection-after-ssl-error-syscall branch from d7fea15 to 3f8b439 Compare February 14, 2023 18:29
@Krzmbrzl
Copy link
Member

Krzmbrzl commented Mar 9, 2023

@davidebeatrici can this be merged?

@davidebeatrici
Copy link
Member

@Krzmbrzl Do we want to adhere to the commit guidelines we use for Mumble here as well?

@Krzmbrzl
Copy link
Member

If we want to auto-generate changelogs, we should consider that. But since the style has not been used yet anyway, I would just merge this as-is. We can decide on the commit style for future PRs :)

@davidebeatrici davidebeatrici merged commit cf6a769 into mumble-voip:master Mar 10, 2023
@davidebeatrici
Copy link
Member

Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants