Variable package size limit

[Krzmbrzl]

Instead of using a hard-coded max size for receiving UDP packets limits what kind of extensions can be made in the future as older clients would simply drop incoming packets that they consider too large, even if technically the Mumble protocol now allows larger packets.

Thus, it would be better to simply take packets in the size in which they come, with some sane upper bound to prevent malicious packets from overflowing a peer.

[davidebeatrici]

d5215ef

Maybe we should increase the default size limit to 4096 or so.

[Krzmbrzl]

d5215ef

Maybe we should increase the default size limit to 4096 or so.

That would still be a hard-limit. The idea is to essentially accept any package size length and resize the buffer dynamically as needed. And in order to not be vulnerable to malicious packages, we should have a hard upper bound, but that should be at least an order of magnitude larger than the largest expected package (maybe around 500KiB or so)

[davidebeatrici]

In that case startUDP()'s bufferSize argument can be (renamed and) used to specify the upper bound, with a default of 500000 bytes.

We can keep the initial buffer size at 1024 bytes.

[Krzmbrzl]

Yeah, sounds good 👍