Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL #137

Closed
wants to merge 17 commits into from
Closed

REPL #137

wants to merge 17 commits into from

Conversation

sornas
Copy link
Collaborator

@sornas sornas commented Apr 16, 2022 •
edited
Loading

  • mumctl hangs on server connect. it waits for more responses. mumrepl works as intended.
  • publish a version of readline-async we can depend on
  • maybe we should just thread
  • output in repl is borked due to missing \r

@sornas sornas changed the base branch from main to crate-restructure-2 April 16, 2022 20:20
@sornas
Copy link
Collaborator Author

sornas commented Apr 16, 2022

This still needs a bit of work. It is almost entirely untested. Known issues will be edited into the PR body as they show up.

Also this will probably have to be squash merged.

This was linked to issues Apr 16, 2022
REPL client #130
Closed
Windows support #136
Open
@sornas sornas mentioned this pull request Apr 16, 2022
Open
@sornas sornas mentioned this pull request Apr 16, 2022
Closed
@sornas sornas marked this pull request as ready for review April 25, 2022 18:53
Base automatically changed from crate-restructure-2 to main May 15, 2022 23:59
@sornas sornas removed the request for review from default-username-852 June 20, 2022 09:51
@sornas
Copy link
Collaborator Author

sornas commented Oct 3, 2022

I think this change is too invasive right now. It's a nice proof of concept showing that it could work. But not with the current development speed.

@sornas sornas closed this Oct 3, 2022
@sornas sornas mentioned this pull request Oct 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows support REPL client
1 participant
@sornas