[MEX-527] Bulk get methods #1535
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- bulk get methods for various fields - update 'feesUSD' compute method signature to enable creating a dataloader for the field; update cache warmer + setter services; update usage in router service - fix unit tests
| (tokenID) => tokenID === lpTokenID, | ||
| ); | ||
|
|
||
| if (farmAddressIndex === -1) { |
There was a problem hiding this comment.
here you used:
if index === -1 { return undefined } else { return from array }
and in the function below you used:
return index === -1 { return undefined } else { return from array }
maybe keep consistency and choose a single way
| return await getAllKeys<string>( | ||
| this.cachingService, | ||
| stakingProxyAddresses, | ||
| 'stakeProxy.stakingFarmAddress', |
There was a problem hiding this comment.
i would recommend putting all the keys in a cache.info.ts because:
- we can easily see all the caching keys in a single place
- we can easily reuse the keys somewhere else
- it helps the overall code by avoiding magic strings in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning
Proposed Changes
getAllKeysutil function) for various fields of pairs, farms, staking farmsHow to test