Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use goroutines manager for trie commit #6611

Open
wants to merge 10 commits into
base: refactor-trie-set-hash
Choose a base branch
from
Open

use goroutines manager for trie commit #6611

wants to merge 10 commits into from

Conversation

BeniaminDrasovean
Copy link
Contributor

@BeniaminDrasovean BeniaminDrasovean commented Nov 14, 2024 •
edited
Loading

Reasoning behind the pull request

  • There are several public trie functions that are all called only when committing the state: GetObsoleteHashes, GetDirtyHashes, GetOldRoot. These can be extracted in a new component

Proposed changes

  • Remove this functions and use a hashesCollector which gathers all the necessary data for a Commit
  • Use goroutines when committing dirty data from a trie.

Testing procedure

  • System tests when all the PRs are merged in the feat branch

Pre-requisites

Based on the Contributing Guidelines the PR author and the reviewers must check the following requirements are met:

  • was the PR targeted to the correct branch?
  • if this is a larger feature that probably needs more than one PR, is there a feat branch created?
  • if this is a feat branch merging, do all satellite projects have a proper tag inside go.mod?

@BeniaminDrasovean
use goroutines manager for trie commit
7f2d3fd
@BeniaminDrasovean
use hashesCollector during commit
27288b2
@BeniaminDrasovean
remove ToString from trie interface
4620444
@BeniaminDrasovean
Merge remote-tracking branch 'origin/refactor-trie-set-hash' into ref…
d106713 
…actor-trie-commit

# Conflicts:
#	common/interface.go
#	trie/branchNode_test.go
#	trie/extensionNode_test.go
#	trie/patriciaMerkleTrie.go
@BeniaminDrasovean
fix after merge
804ea57
@BeniaminDrasovean
Merge remote-tracking branch 'origin/refactor-trie-set-hash' into ref…
df3865b 
…actor-trie-commit

# Conflicts:
#	trie/branchNode.go
#	trie/extensionNode_test.go
#	trie/patriciaMerkleTrie.go
#	trie/rootManager.go
@BeniaminDrasovean
fix after merge
6ad3b96
@BeniaminDrasovean
commitDirty end goroutine processing
22912c9
@BeniaminDrasovean
Merge remote-tracking branch 'origin/refactor-trie-set-hash' into ref…
4d5f3e2 
…actor-trie-commit
@BeniaminDrasovean
add mutex for baseNode
354812c
@BeniaminDrasovean BeniaminDrasovean marked this pull request as ready for review December 19, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@BeniaminDrasovean