Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of resources meta.xml #491

Merged
merged 4 commits into from
May 23, 2024

Conversation

Fernando-A-Rocha
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha commented May 17, 2024

This PR introduces the following changes:

  • author tag added in resources info that didn't have it (MTA contributors (github.com/multitheftauto/mtasa-resources))
  • version tag added in resources info that didn't have it (1.0.0)
  • unnecessary <?xml line removed from all .map and meta.xml files that had it
  • unused mod="deathmatch" tag removed from all .map files`

Feel free to give your opinion.

To me, the most important change is adding version tags to all resources, so version control standards can be enforced like they are in community.mtasa.com. Example of good practice: https://community.multitheftauto.com/index.php?p=resources&s=details&id=3716

@T-MaxWiese-T
Copy link
Contributor

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

@Fernando-A-Rocha
Copy link
Contributor Author

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

I believe so. This is the responsibility of us, contributors and maintainers of this repository. I don't see why a resource version shouldn't be bumped when it's changed, despite the fact that it's not that useful for now. Maybe in the future there can be a resource update checker.

@T-MaxWiese-T
Copy link
Contributor

Does it mean that from now on if a resource is changed for a future release the version number has to be increased?

I believe so. This is the responsibility of us, contributors and maintainers of this repository. I don't see why a resource version shouldn't be bumped when it's changed, despite the fact that it's not that useful for now. Maybe in the future there can be a resource update checker.

It is already possible to update resources via the server console.
The admin panel should actually also have this option. There should be a new lua function for this:
bool upgradeResources ( [ bool upgradeAll = true, resource targetResource = nil ] )
And a function that returns the resource names that need to be updated and the latest version:
table getUpgradeResources ( [ bool allResources = true, resource targetResource = nil ] )

@Dutchman101 Dutchman101 merged commit 6713b07 into multitheftauto:master May 23, 2024
1 check failed
@Fernando-A-Rocha Fernando-A-Rocha deleted the xml-cleanup branch June 19, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants