Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Exception inheritance #54

Open
Calosha opened this issue Jan 29, 2021 · 3 comments · May be fixed by #60
Open

Wrong Exception inheritance #54

Calosha opened this issue Jan 29, 2021 · 3 comments · May be fixed by #60
Assignees
@Swanand01
Labels
bug good-first-issue

Comments

@Calosha
Copy link

Calosha commented Jan 29, 2021

PanSchError must inherit from Exception instead of BaseException so I could be caught with

except Exception as e:

class PanSchError(Exception):
    """
    Base class for all pandas_schema exceptions
    """
@Swanand01
Copy link

Hi, I would like to take this up please.

@multimeric
Copy link
Owner

Go for it, thank you!

@multimeric multimeric linked a pull request May 16, 2021 that will close this issue
Fixed wrong Exception Inheritance #60
Open
@multimeric
Copy link
Owner

Yeah, I wrote that a long time ago and I have no idea why I thought it was a good idea to inherit from BaseException.

@multimeric multimeric linked a pull request May 16, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Swanand01 Swanand01

Labels
bug good-first-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed wrong Exception Inheritance Swanand01/PandasSchema
3 participants
@Calosha @multimeric @Swanand01