Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all protocol definitions into this package #108

Closed
Stebalien opened this issue Jul 18, 2019 · 1 comment · Fixed by #111
Closed

Move all protocol definitions into this package #108

Stebalien opened this issue Jul 18, 2019 · 1 comment · Fixed by #111
Assignees
@bigs

Comments

@Stebalien
Copy link
Member

Due to multiformats/multiaddr#70, we can't handle mulitaddrs we don't understand. For now, we should just understand them all.
@Stebalien
Copy link
Member Author

Specifically, move:

  • p2p-circuit from go-libp2p-circuit
  • ws/wss from go-ws-transport
  • dns{4,6,addr} from go-multiaddr-dns (not the entire package, just the protocol definitions).

@Stebalien Stebalien mentioned this issue Sep 17, 2019
Closed
@godcong godcong mentioned this issue Sep 18, 2019
Merged
Stebalien added a commit that referenced this issue Sep 18, 2019
@Stebalien
Merge pull request #111 from godcong/master
37eceec 
fix #108
This was referenced Sep 19, 2019
Merged
Merged
Merged
Stebalien added a commit to libp2p/go-libp2p-circuit that referenced this issue Sep 19, 2019
@Stebalien
move protocol definitions to go-multiaddr
b8128e2 
see multiformats/go-multiaddr#108
@Stebalien Stebalien mentioned this issue Sep 19, 2019
Merged
Stebalien added a commit to libp2p/go-libp2p that referenced this issue Sep 19, 2019
@Stebalien
dep: update go-multiaddr
1938505 
for multiformats/go-multiaddr#108
marten-seemann pushed a commit to libp2p/go-libp2p that referenced this issue Jul 1, 2022
@Stebalien
move protocol definitions to go-multiaddr
3b3e910 
see multiformats/go-multiaddr#108
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bigs bigs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix https://github.com/multiformats/go-multiaddr/issues/108
2 participants
@bigs @Stebalien