Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote platform message data to have similar structure with local messages #98

Open
S-S-X opened this issue May 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@S-S-X
Copy link
Member

S-S-X commented May 11, 2023

Remote message data can be and is bit different but should be restructured before handing it out to event handlers and/or chat API.

Probable either just before calling handle_data or after first sanity check and before first event handler callbacks here:

beerchat/web/rx.lua

Lines 3 to 10 in 0f106b1

local function handle_data(data)
if not data or not data.username or not data.text or not data.gateway or not data.protocol then
return
end
if not beerchat.execute_callbacks('on_http_receive', data) then
return
end

@S-S-X S-S-X added the enhancement New feature or request label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant