From 58250dcfffd64800de7e759100447ca30f0141eb Mon Sep 17 00:00:00 2001
From: Kartal Kaan Bozdogan <kartalkaanbozdogan@gmail.com>
Date: Wed, 20 Dec 2023 22:28:47 +0100
Subject: [PATCH] Allow computations using other computations via .asStream  
 Useful for the "computed query" pattern

---
 lib/src/computed.dart   |  3 --
 test/computed_test.dart | 69 +++++++++++++++++++++++++++++++++++++++--
 2 files changed, 67 insertions(+), 5 deletions(-)

diff --git a/lib/src/computed.dart b/lib/src/computed.dart
index 6bd5bdd..3fb7aa3 100644
--- a/lib/src/computed.dart
+++ b/lib/src/computed.dart
@@ -227,9 +227,6 @@ class ComputedImpl<T> {
 
   ComputedSubscription<T> listen(
       void Function(T event)? onData, Function? onError) {
-    if (GlobalCtx._currentComputation != null) {
-      throw StateError('`listen` is not allowed inside computations.');
-    }
     final sub = _ComputedSubscriptionImpl<T>(this, onData, onError);
     if (_novalue) {
       try {
diff --git a/test/computed_test.dart b/test/computed_test.dart
index 73679d3..494504c 100644
--- a/test/computed_test.dart
+++ b/test/computed_test.dart
@@ -640,6 +640,72 @@ void main() {
     sub.cancel();
   });
 
+  test('computed query pattern works', () async {
+    final controller = StreamController<int>.broadcast(
+        sync: true); // Use a broadcast stream to make debugging easier
+    final source = controller.stream;
+
+    final queryStream = Computed(() => source.use)
+        .asStream
+        .map((key) => Future.microtask(() => key));
+
+    var cCnt = 0;
+
+    final result = $(() {
+      cCnt++;
+      return queryStream.use.use;
+    });
+
+    var expectation = 0;
+    var callCnt = 0;
+
+    final sub = result.listen((event) {
+      callCnt++;
+      expect(event, expectation);
+    }, (e) => fail(e.toString()));
+
+    await Future.value();
+    expect(cCnt, 2);
+    expect(callCnt, 0);
+
+    controller.add(0);
+
+    expect(cCnt, 2);
+
+    await Future.value(); // For the asStream to propagate the result
+
+    expect(cCnt, 4);
+    expect(callCnt, 0);
+
+    await Future.value(); // For the "query" to complete
+
+    expect(cCnt, 6);
+    expect(callCnt, 1);
+
+    controller.add(0);
+
+    await Future.value();
+    await Future.value();
+
+    expect(cCnt, 6); // First computation terminates propagation
+    expect(callCnt, 1);
+
+    expectation = 1;
+    controller.add(1);
+
+    await Future.value(); // For the asStream to propagate the result
+
+    expect(cCnt, 8);
+    expect(callCnt, 1);
+
+    await Future.value(); // For the "query" to complete
+
+    expect(cCnt, 10);
+    expect(callCnt, 2);
+
+    sub.cancel();
+  });
+
   group('respects topological order', () {
     test('on upstream updates', () {
       for (var streamFirst in [false, true]) {
@@ -894,8 +960,7 @@ void main() {
     }, (e) {
       expect(flag, false);
       flag = true;
-      expect(e, isA<StateError>());
-      expect(e.message, '`listen` is not allowed inside computations.');
+      expect(e, isA<ComputedAsyncError>());
     });
 
     await Future.value();