You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
By the style guide (and enforced by the linter), the types of all properties of React components must be defined in that component's propTypes field. Properties can be flagged as required, which prompts React to throw warnings when a required property is not passed in.
Currently, we define the types of these properties but none are marked required, even though many are required by the components' logic. We should mark these properties as required, and leave alone the properties that are optional (we should also make sure that optional properties are indeed treated as optional within the component, e.g. by checking for their existence before using them).
The text was updated successfully, but these errors were encountered:
By the style guide (and enforced by the linter), the types of all properties of React components must be defined in that component's
propTypes
field. Properties can be flagged as required, which prompts React to throw warnings when a required property is not passed in.Currently, we define the types of these properties but none are marked required, even though many are required by the components' logic. We should mark these properties as required, and leave alone the properties that are optional (we should also make sure that optional properties are indeed treated as optional within the component, e.g. by checking for their existence before using them).
The text was updated successfully, but these errors were encountered: