Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Fixes #834 #835 Bookmarks resize issues #888

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fixes #834 #835 Bookmarks resize issues #888

merged 1 commit into from
Dec 17, 2018

Conversation

keianhzo
Copy link
Contributor

Fixes #834 #835 Fixed bookmarks resize issues and refactored browser and bookmarks code into a "browser window" widget so we just need to use a single surface texture for any view that belongs to the browser window space (bookmarks, history, browser, etc)

@cvan cvan added this to the v1.2 milestone Dec 14, 2018
Copy link
Contributor

@cvan cvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 👍 I tested, and this nicely fixes both #834 and #835.

P.S. I filed this nit issue that I forgot to file from earlier: issue #895

@MortimerGoro
Copy link
Contributor

MortimerGoro commented Dec 17, 2018

Tested and I didn't find any issue, good work!

Copy link
Contributor

@caseyyee caseyyee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@cvan cvan merged commit 52b7e36 into master Dec 17, 2018
@cvan cvan deleted the browser-window branch December 17, 2018 18:42
@bluemarvin
Copy link
Contributor

Looks like this broke the bookmark page on every platform but Oculus.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants