This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Fixes #3643 Telemetry crash fix #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keianhzo
force-pushed
the
v12/telemetry_crash_fix
branch
from
1619e26 to
924a304
Compare
keianhzo
force-pushed
the
v12/telemetry_crash_fix
branch
from
924a304 to
3ccae40
Compare
daoshengmu
approved these changes
Jul 7, 2020
bluemarvin
approved these changes
Jul 7, 2020
Comment on lines
+55
to
+56
| TelemetryWrapper.init(this, EngineProvider.INSTANCE.getDefaultClient(this)); | ||
| GleanMetricsService.init(this, EngineProvider.INSTANCE.getDefaultClient(this)); |
There was a problem hiding this comment.
It's unfortunate glean requires this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3643 The Telemetry service needs to get initialized in the Application onCreate as the service can be called when the app is not running and that only calls the Application onCreate, otherwise this crash happens.
I had to add a custom TestApplication for testing as the Unit testing initialization doesn't seems to provide a different process for the crash service as defined in the manifest and the GeckoRuntime crashes with:
java.lang.IllegalArgumentException: Crash handler service must run in a separate processAlso for some reason the Application onCreate is called from a different process the first time the app is launched and the GeckoRuntime is not correctly initialized and we don't get any content paints. I've added the same check as Fenix does to make sure we are running in the main process or just return otherwise.