Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

The default values displayed in the input fields from the Display card are not unfocused when clicking inside the input field #2859

Closed
Softvision-RemusDranca opened this issue Feb 25, 2020 · 3 comments · Fixed by #3415
Assignees
Labels
in progress [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Milestone

Comments

@Softvision-RemusDranca
Copy link

[Affected Versions]:

[Affected Platforms]:

  • HTC Vive Focus Plus - Android 7.1.2
  • Oculus Quest - Android 7.1.1
  • Pico Neo 2 - Android - 8.1.0

[Prerequisites]:

  • The headset is turned on and the app is opened.

[Steps to reproduce]:

  1. Open the Display card from Settings.
  2. Click the "Edit" button for the "Homepage" option.
  3. Click inside the displayed input field.
  4. Observe the behavior.

[Expected results]:

  • The value inside is no longer highlighted and the caret is displayed.

[Actual results]:

  • The value remains highlighted and the text caret is not displayed.

[Notes]:

  • This issue is also reproducible with the input fields for the "Display Density" and "Display DPI" options.
  • This issue is not reproducible when editing the options a second time, while having different values.
  • Attached is a screen recording of the issue: link.
@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Normal issue Label for QA to mark normal issues logged label Feb 25, 2020
@bluemarvin bluemarvin added this to the #10 features milestone Feb 25, 2020
@emstanley emstanley modified the milestones: #10 features, #11 polish Mar 23, 2020
@keianhzo
Copy link
Contributor

keianhzo commented May 1, 2020

@Softvision-RemusDranca I think this is already fixed.

@Softvision-RemusDranca
Copy link
Author

@keianhzo I've retested this issue and it's still reproducible with the Firefox Reality version 10 RC4 (2999129). The default strings remain highlighted when clicking inside the input field.

Tested on HTC Vive Focus (Android 7.1.2), Oculus Quest (Android 7.1.1), and Pico Neo 2 (Android - 8.1.0) devices.

daron-walters added a commit that referenced this issue May 21, 2020
… the default valeu

Fixes #2859 Removed onclick listener whose sole purpose was to highlight default values and set focus
daron-walters added a commit that referenced this issue May 22, 2020
keianhzo pushed a commit that referenced this issue May 28, 2020
@Softvision-GeluHaiduc
Copy link

I have verified that this issue is no longer reproducible with the latest Firefox Reality version 11-141492311 (a9b58ee) installed on the Oculus Go, Pico Neo2 and Pico G2 4K headsets.
Now, the default values displayed in the input fields from the Display card are unfocused when clicking inside the input field and the text caret is displayed at the end of the string.

@Softvision-GeluHaiduc Softvision-GeluHaiduc added the [QA]:Verified fixed Label for QA to mark verified fixed issues label May 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.