This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Prevent alt+space from crashing. Fixes #2580 #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluemarvin
added
the
crash 🔥
keianhzo
approved these changes
Jan 9, 2020
lissyx
pushed a commit
to lissyx/FirefoxReality
that referenced
this pull request
Jan 21, 2020
keianhzo
added a commit
that referenced
this pull request
Jan 22, 2020
* Report accurate windows mean Reset the windows count when resuming the app to report a more accurate mean. Force send the telemetry status every time the app starts Revert "Force send the telemetry status every time the app starts" This reverts commit a491bdb. * Fix typo * Remove spaces * Import l10n. (#2277) * Remove the version check, always show if it's not been displayed before (#2282) * Remove notifications when resizing and opening library panels (#2285) * Dismiss context menu when scrolling (#2271) * Import l10n. (#2291) * Limit total number of GeckoSessions created to prevent OOM (#2295) * Only capture screenshots if the first paint is ready (#2304) * Upgrade GeckoView to 72.0.20191118093852 (#2306) * Fix wrongly positioned pasted text in the URL bar. Fixes #2300. (#2305) * Deactivate current session when receiving a new tab (#2284) * Deactivate current session when receiving a new tab * deactivate the previous session if not in fullscreen * Add support for keyboard domains (#2308) * Adds for keyboard domains Set column width as the max of each row Fix keyboard panels column width * Fix delegate name * Fix Polish TLD (#2310) * Check if selection action is available before executing it. (#2317) * Make onCheckIsTextEditor return false when window is resizing. Fixes #2298. (#2313) * Enable software rendering (#2019) (#2184) * Enable software rendering (#2019) * Add a developer setting * Request focus when clicking URL bar icon buttons. Fixes #2301. (#2312) * Delete all instances of the history url record (#2314) * Improve session snapshot captures (#2321) * Add hover animations to the languages and popup row icons (#2332) * Avoid tinting the profile icon for FxA honeycomb (#2334) * Fixes what's new dialog background color (#2335) * Do not release GeckoDisplay when switching visible window sessions (#2336) * Do not erase the entire text when backspace is long-pressed (#2324) * Fix navigation bar notification alignment (#2325) * Fix Selection Action menu alignment on the Awesome Bar (#2331) * Ensure parent session is active before setting in Window (#2339) * Allow popup tabs to live long enough to initialize before suspending (#2338) * Import l10n. (#2340) * Don't keep the text selected after it's copied. (#2342) * Reuse the last frame and tracking when a VR frame is discarded in Oculus (#2341) * Correctly update media control selected projection when entering a immersive video (#2345) * Update children widgets recursively (#2346) * Import l10n. (#2352) * Dismiss library panels explicitly (#2353) * Prevent setting tracking protection state on suspended Sessions. Fixes #2360 (#2361) * Adds support for multiple accounts last sync time (#2349) * Invert horizontal scrolling for Oculus Quest joystick (#2343) * Import l10n. (#2363) * Making fast scroller still be available to scroll its last part. (Fixes #1986) (#2364) Good catch @daoshengmu, works great * Migrate telemetry pings to Glean (Stage 2). Fixes #2230 (#2241) * Fixes UIDialog focus issues (#2351) * Fix focus issues in dialogs * Refactored common behaviors to UIDialog * Just use WorldClickListener for UIDialog dismiss * Ensure Sessions are recreated correctly when clearing data (#2362) * Ensure Sessions are recreated correctly when clearing data - Fixes #2356 - Fixes issue where switching Multiprocess in the developer panel would freeze the session. - Fixes default private browsing page not getting displayed when recreating a private browsing session. * Improve onFirstContentfulPaintnotification * Dismiss the projection menu when clicking on any other media button (#2368) * FxA updates (#2129) * Use GeckoWebExecutor for FxA Services * Get rid of a complex getAuthicationUrlAsync Per #1973 (comment) * Remove WorkManager initialization Per #1973 (comment) * Restore mistakenly removed callback * Rebase updates * Revert the workmanager fix, there are still crashes without this * Call prefs before creating the runtime * Megazord integration * Rebase updated * Remove unused telemetery. * Moving telemetry computation off client. * Import l10n. (#2365) * Fix for disappearing context menus (#2376) * Bump GV to 72.0.20191126093448 (#2371) * Fix navigation bar notification alignment (#2369) * Revert explicit and use LoadRequest event to close library panels (#2367) * Sign-out dialog (#2374) * Revert UI animations (#2380) * Revert all UI ease animations * Moved hiding library panels to onPageStart * Use WebExtension for youtube redirects instead of the GV API (#2378) * Fix cropped items in Selection Action menu (#2382) * Use the FxR canGoBack() logic instead of the GeckoSession.canGoBack() logic when dispatching onCanGoBack event (#2387) * Handle potential exception capturing snapshots (#2386) * Handle potential exception when GeckoSession.capture() is called * Reset the mCaptureOnPageStop member when switching sessions * Tabs and FxA Telemetry (#2327) * Avoid duplicated GeckoSession setActive calls (#2392) * Avoid duplicated GeckoSession setActive calls * Ensure we save state and call Telemetry * Disable multiprocess by default (#2393) * Use CopyOnWriteArrayList for all Session event listeners (#2401) * Handle hardware acceleration switch when reseting dev options (#2398) * Import l10n. (#2391) * Bump FxR to 8 (#2397) * Import l10n. (#2407) * Bump GV to gv_72.0.20191202091209 (#2405) * Fix library items styles (#2402) * Import l10n. (#2418) * Bump mozilla-speech to v1.0.9 (#2399) * Add telemetry for creating new windows. Fixes #2347 * Import l10n. (#2433) * Keyboard polishing (#2425) * Update keyboard domains * Force capitalize initial keyboard letter * Remove hardcoded languages * Make keyboard keys sticky (#2420) * nits * Make keys sticky * Improved History (#2417) * Add support for tab/windows adb parameters (#2423) * Close Library panels when clicking on an anchor (#2403) * Import l10n. (#2434) * Bump GV to v73.0.20191211094640 (#2454) * fix typo isDebugLogginEnabled -> isDebugLoggingEnabled (#2456) * Bump GV to v73.0.20191212095326 (#2467) * By passing WebXR permission prompt. * Bump GV to v73.0.20191212095326 * Reposition UI in front of the user when exiting a VR video. (#2447) * Do not forward motion events to GeckoSession when library panels are visible in the window (#2476) * Making WaveVR/OculusVR controllers support haptic feedback (#2198) * Making WaveVR controllers support haptic feedback. * Making Oculus Quest support haptic feedback. * Making Quest thumbRest always be false. * Glean build system updated (#2439) * Youtube Web Extension refactor (#2487) * Fix invalid play/pause button state when entering immersive videos (#2488) * Import l10n. (#2503) * Support Glean metric unit tests (#2444) * Support Glean unit test. * Run Glean unit test in Taskcluster. * Dialogs refactoring (#2468) * Dialogs refactoring Restart dialog refactored Crash dialog refactored Removed Max Windows dialog PopUp block dialog refactored Collect voice samples refactored Open Settings links in new tabs What's new and Sign Out dialogs refactored Voice Search Dialog refactored Added empty popup exceptions panel text Position adjustments Clear Cache dialog refactored Removed unused resources Browser alert and confirm refactor * Restore the Restart dialog checkbox * Fix broken crashcontent crashes receiver * Rename ClearCacheDialogWidget to ClearHistoryDialogWidget wip * Restore the Sad Fox icon for the crash dialog * Ensure that the crash dialog checkbox is always unchecked when showing * Move the sad fox icon it to the right folder * Import l10n. (#2515) * Improve youtube layout (#2509) * URL Bar styles fixes (#2517) * Fixes url bar icons private mode style * Keep the url bar outline with children are pressed * Setting for enable/disable restoring tabs (#2513) * Add a setting to enable/disable tab restoration * Save state before restarting * Use out of bounds coordinates when dispatching ACTION_HOVER_EXIT (#2510) * Show Settings instead of toggling after a fxa login (#2469) * Show Settings instead of toggling after a fxa login * Standardize annotations to use androidx * Import l10n. (#2522) * Import l10n. (#2540) * Call the crash reported form a background thread (#2531) * Fix focus outlines appearing on some UI elements (#2520) * Fixed the bookmarks item delete button state (#2470) * Fixed the bookmarks item delete button state * Un-hover when touch action is cancelled * Import l10n. (#2544) * Import l10n. (#2556) * Import l10n. (#2572) * Only show login success if account creation was user initiated (#2570) * Add invalid certificate bypass to ssl error pages (#2530) * wip * Add support for bypassing the SSL certificate exceptions * Leave only the temporary option when bypassing * Use system language as default content language (#2518) * Use system language as default content language * Fix checked available language when resetting * Add cap flags as needed for WebXR related changes in GeckoView (#2516) (cherry picked from commit 3621a19) * Import l10n. (#2574) * Clear projection menu selection if there isn't one selected (#2500) * Clear projection menu selection if there isn't one selected * Unset video projection when exiting immersive Video mode Co-authored-by: Manuel Martin <[email protected]> * Fix cut media controls at the bottom (#2579) * Make the base dialog taller to fit all the languages (#2581) * Use show/hide instead of setVisible to ensure back handler is removed (#2582) * Do not send unstack callbacks for child sessions (#2588) * Import l10n. (#2590) * Import l10n. (#2591) * Disable tracking requirement on Quest Store build. Fixes #2551 (#2589) * Make dialog checkbox to wrap content height (#2592) * Bump GV to 74.0.20200107095722 (#2597) * Hide youtube fullscreen share button (#2598) * Import l10n. (#2599) * Update tittle bar media status when switching tabs (#2584) * Dialog stacking (#2573) * Use a single global connection dialog instead of per window * Dialog stacking * Prevent alt+space from crashing. Fixes #2580 (#2593) * Import l10n. (#2613) * Enable e10s by default (#2615) * Fixes #2524 Honeycomb button clipping (#2601) * Honeycomb button clipping * Forward event if not inside * Do not scale font size anymore in the youtube webextension (#2610) * Set youtube viewport before DOMContentLoaded (#2596) * Set youtube viewport before DOMContentLoaded * Restore Youtube UA overrides * Move youtube reload code * Awesome bar copy url (#2604) * Bump GV to 74.0.20200107215758 (#2619) * Set max-scale and min-scale values in Youtube's viewport (#2616) * Workaround for Youtube homepage layout (#2617) * Fix skybox reverting to non-void after exiting theatre mode. (#2606) * Enable hardware renderer and don't draw after onStop/onDestroy (#2482) * Added check to avoid the nullpointerexception when focusing a window (#2477) * Added check to avoid the nullpointerexception * Check attached window null * Import l10n. (#2622) * Fixes L10n with the prompt widget (#2607) * Update third party hash (#2632) * Handle the new autoplay permissions (#2624) * Revert to realtime sync (#2586) * Fix Youtube 360 stereo video layout issues (#2634) * Correctly focus front window after another is closed (#2640) * Preemptive null checks to avoid crashes in the TitleBar widget (#2643) * Add 1 column Youtube CSS layout rule (#2644) * Fix switch clipping. Fixes #2642 (#2646) * Autodetect 360 stereo projection (#2635) * Improved L10n support for settings (#2609) * Import l10n. (#2649) * Fixes #2670 Language fixes (#2672) * Fix for Pico Taiwanese Chinese locale * Language fixes * Fallback to en-US for Display/Voice when OS language is not supported * Focus window can handle null windows. Revert the null check (#2666) * Close dialog after clearing and reseting the radio button (#2667) * Call dismiss instead of hide when dismissing by a world click on dialogs (#2678) * Revert "Enable e10s by default (#2615)" (#2687) This reverts commit 91e3eaa. * Fixes voice language issue when reset. Also force save the display one (#2692) * Avoid double removing items when deleting (#2658) * WIP: Add DeepSpeech * Ds update (#2261) * Hide scrollbar in Awesome bar suggestion list if all the content fits. (#1701) * Fix flickering when closing a window (#1700) * Updated scrollbar theme (#1706) * Update Bookmarks UI (#1704) * Update Bookmarks UI * Fixed crash when scrolling * Add missing Destroy() call in DeleteLayer() (#1707) * Hide notification if tray is detached or hidden (#1708) * Fix Surface leaks when closing windows or removing widgets (#1716) * Fix leak when closing a window (surface.release() not called) * Ensure that surface is released when a widget is removed (before waiting for releaseWidget() call) * Do not recreate the tooltip if already created * Improve WindowWidget.releaseWidget * Hide/show Top and TitleBar widgets instead of recreating them each time * Do not dim environment when while selecting one. (#1720) * Update tray when a window is closed (and focus didn't change) (#1723) * Set session stack active state based on the window visibility (#1717) * Do not make the session inactive if we are in VR video mode (#1731) * Update third party hash to include WaveVR 3.1.1 beta (#1724) * Tray position fix when exiting from fullscreen mode and video vr mode (#1735) * Fixed the gap between video control buttons (#1732) * Fix for the fullscreen controls middle gap between buttons * Added a padding to fix the gap * Add a background layout to cover the gap * Do not show the multi-window controls if the window is in theatre mode. (#1739) * Update bookmarks tray button state after dismissing the notification (#1740) * Hide the context when the window loses focus (#1741) * Hide context buttons when the action is canceled (#1743) * Save the focused window between regular and private sessions (#1745) * Import strings from android-l10n (#1769) State: mozilla-l10n/android-l10n@6d2fe83 * Null check focused window when entering/exiting private mode (#1763) * Pause/resume other windows when entering/exiting immersive mode (#1747) * Pause other windows when entering immersive mode * Improve pause/resume state handling * Add missing copy properties to Placement.copyFrom() (#1766) * Fix crash when the app is closed while playing 360 videos (#1771) * Fix Oculus layers array stack overflow (#1764) * Fix Oculus layers array stack overflow * It's preferable to hide the windows first to avoid max layers race conditions * Fix item not being set before the menu measure is called (#1768) * Update 1.5x resize button style when entering private mode, (#1773) * Do not keep a default language (#1772) * Fix fullscreen video control panel z-order issues (#1767) * Restore window size/position if the app is exited while in fullscreen (#1778) * Restore window size/position if the app is exited while in fullscreen * Refactor resize and fullscreen placements to window for better restoring * Fix showing the top bar while in theatre mode * Fixes a crash when quitting the app while in resize mode * Fixes the add/remove icon turning into a check icon when clicking (#1779) * Update FxR Java logging to include class name in LOGTAG (#1699) * Add error log for when override environment path can not be found (#1712) * Save autoplay state. Fixes #1781 (#1785) * Do not animate navigation bar fullscreen exit in onDestroy (#1786) * Show empty history when the last item is manually removed (#1788) * Added info regarding variable substitution (#1789) * Bump GeckoView to 71.0.20190909095540 (#1802) * Prevent crash reporter from being triggered once onDestroy has been called. (#1801) * Update voice collection dialog text (#1803) * Bump FxR version to 1.5 (#1780) * Remove unnecessary logs and downgrade other log messages from error to debug (#1711) * Add name property to WidgetPlacement (#1765) * Prevent Widgets from being retained by the MotionEventGenerator after a pause. Fixes #1728 (#1811) * Maintain projection menu state between views. Fixes #1807 Fixes #1808 (#1820) * Use `substitute-local-geckoview.gradle` from Bug 1533465 for local Ge… (#1579) * Use `substitute-local-geckoview.gradle` from Bug 1533465 for local GeckoView substitutions. (#987) See discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=1533465. * Handle dependencies substitution in a more standard way Move geckoViewLocalTopobjdir and geckoViewLocalTopsrcdir to local.properties and handle user.properties the same way. * Fix servo variable name * Prevent NavigationBarWidget from restoring the incorrect window position when dropping out of fullscreen. Fixes #1798 (#1810) * Use correct lable for older history items. Fixes #1824 (#1826) * Import strings from android-l10n (#1828) State: mozilla-l10n/android-l10n@e78d586 * Correctly check for IME Action when processing the done key. Fixes #1816 (#1827) * Media control needs to attach to its window when entering VR video. Fixes #1830 (#1834) * Remove Window and Max Window Size settings. Fixes #1822 (#1835) * Update .taskcluster.yml to v1 (#1809) * Gradle update required by AS 3.5.0 (#1762) * Speculative fixes for keyboard crashes. Fixes #1821 (#1836) * Fix crash from URI.create unhandled exceptions. Fixes #1844 (#1845) * Clear Navigation Bar focus when window changes focus. Fixes #1841 (#1848) * Write a file containing the crash files location. Fixes #1846 (#1847) * Ensure History and Bookmark labels are shown in url bar when they are visible. Fixes #1818 (#1849) * Add support for clearing window color before GV does the first composition (#1697) * Add support for clearing window color before GV does the first composition * Update to use new GeckoView onFirstContentfulPaint() callback * Fix HTC * Bump GV version to 71.0.20190919094654 * RussianLangInOptions (#1856) * Fixes lanaguages when using lang-script-region type. (#1860) * Disable WebRender until it works with FxR (#1861) * Remove most 32bit builds from taskcluster builds. Fixes #1855 (#1867) * Switch the default window color from asphault to iron. Fixes #1862 (#1864) * Check both height and width of border for change in length. Fixes #1851 (#1868) * Import strings from android-l10n (#1869) State: mozilla-l10n/android-l10n@d10506f * Resize library panels correctly for small window sizes (#1871) * Import strings from android-l10n (#1881) State: mozilla-l10n/android-l10n@97355ff * Library polishing (#1879) * Do not overwrite first draw callback on proxified layers. (#1885) * Remove unnecessary bookmarks DB code (#1870) We are already using AC for bookmarks so this code along with the migration code shouldn't be necessary anymore and should be safe to remove. * Keep preload history. Fixes #1806 (#1825) * Improve depth sorting: do not clamp hitPoint used for ndc calculation (#1887) * Disable 32 bit builds for pull requests (#1888) * Increase click target size for buttons inside Library views (#1873) * Increase click target size for buttons inside Library views * Rebase fixes * Add support for feature branch builds on taskcluster (#1889) * Import strings from android-l10n (#1894) State: mozilla-l10n/android-l10n@10559d7 * Unify MediaControls back button and controller back action (#1891) * Include parenting check in depth sorting. Optimize depth sorting. (#1893) * Bump GeckoView to 71.0.20190930095343 (#1901) * Change app version to use new system (#1911) * No longer save number of private windows on exit. Fixes #1899 (#1902) * Clear GeckoSession histroy when clearing history. Fixes #1749 (#1903) * Hide context menus when window activation state changes (#1906) * Check long press flag in keyboard onText() callback (#1907) * Replace "Caribbean" color with "Azure" color (#1909) * Fix top bar glitch when moving windows (#1910) * Update keyboard IME action when input is restarted (#1916) * Restore userAgentOverride when restoring state (#1125) (#1913) When restoring state using session.restoreState, `onLoadRequest` is not called which causes FxR's UA override logic to not run. To fix this, we remember the UA override string and restore it. * Update UIButton to better manage multiple states. Fixes #1837 (#1920) * Fix cropped awesome bar placeholder (#1908) * Fix vertical gap in resize bar (#1917) * Set correct color scheme for awesomebar buttons in private mode (#1922) * Handle exceptions thrown by java.net.URI (#1918) * Set blue hover color for long press menu (#1921) * UI Polishing (#1915) * URL text hint truncates Quick and dirt fix for this, better URL UI handling in 1.5 * Language settings panels fixes * Tooltip fixes * Languages and display settings style updates * Vertical separators for the tray * Responsive library layout * Reverte of URL hint fix * Scrollbars standarization (#1925) * Fix video projection menu position Media Controls (#1927) * Import l10n. (#1932) * Add wavevr assets to wavevr store build (#1929) * Making Focus Plus use WVR_InputId_Alias1_Trigger to check trigger only. Fixes #1930. (#1931) * Fix visual glitches on the hint fading edge (#1933) * Import l10n. (#1938) * Import l10n. (#1940) * Import l10n. (#1942) * Import l10n. (#1943) * Import l10n. (#1971) * Update title bar position after neighbour window is resized (#1948) * Bump FxR version to 6 (#1950) * Update taskcluster scripts to support v2 signing (#1954) * Standarize dialogs y & z positions (#1949) * Add support for Bluetooth keyboards. Fixes #775 (#1878) * Bump GeckoView to 71.0.20191011093010 (#1962) * Keyboard updates: Polish, Danish UIS-6 and bug fixing (#1890) * Keyboard updated Added Danish and Polish and updated the Spec to UIS-6_Keyboard_021 * Added Danish and Polish to display and voice languages * Fixed spacebar strings for polish and Danish * Updated Polski language string * Upgrade to GeckoView 71.0.20191014095234. Fixes #1777 (#1981) * Ensure releases are only built once (#1965) * Import l10n. (#2000) * Implement Copy Paste (#2004) * Implement Copy Paste (#1883) * Implement Copy Paste * Address review feedback * Fix rebase issue * Copy paste improvements (#1994) * Import l10n. (#2007) * Import l10n. (#2010) * Use a fixed sqliteassethelper library version (#1998) This will also avoid some taskcluster failures as it will use the cached one * Revert "Gradle update required by AS 3.5.0 (#1762)" (#1900) This reverts commit df21d29. * Dutch keyboard (#1992) * Bump GV to 71.0.20191018095340 (#2018) * Finnish keyboard (#1995) * Swedish keyboard (#1996) * Norwegian Keyboard (#1997) * Norwegian Keyboard * Update non_L10n.xml * Import l10n. (#2023) * Fix floating-point suffix unsupported prior to GLSL ES 3.00 (#2015) * Pop Ups blocking (#1987) * Pop Ups blocking * Added a switch to manage the sites. Text and UI updates * Rebase fixes * Review fixes - Deny -> Block - Fixed sites added multiple times - Inverted site switch on -> blocked, off -> allowed * Revert switch text * Import l10n. (#2029) * Import l10n. (#2031) * Import l10n. (#2037) * Import l10n. (#2039) * Survey feedback link (#2027) * Survey feedback link * Separate link from text * Import l10n. (#2041) * Added support for a telemetry enabled/disabled ping (#1936) * Added support for a telemetry enabled/disabled ping Changed the telemetry status key name Revert "Changed the telemetry status key name" This reverts commit 6a632dc542ce40b6890e4b6c50c1c33a648d813c. * Send the telemetry status ping if it's an update and telemetry was off * Shorten the telemetry status string length * UI transitions animations (#1934) * Import l10n. (#2049) * Tabs implementation (#2051) * Tabs implementation (#1963) Merging and opening issues for the above after talking to @MortimerGoro * Tabs implementation * Refactor session restore code. Fix nits. * Rename isComposited method * Fix potential NullPointerException crash when focus changed after a the TabWidget is released without hiding it before * Update session last use when changing active windows * Correctly sync tabs after closing * Close the TabsWidget when the active window changes. * Tabs polish (#2028) * Tabs UI polish * Set correct tab title for contend feed * Correctly handle onNewSession (e.g window.open()) * Fix onDestroy crash * Implement BitmapCache for tab snapshots * Use a single instance of TabWidget. Improve dismiss detection. * Add open new tab notificaion and context menu action. * Dispatch BitmapCache callbacks on the Main Thread. Scale bitmaps before saving them to disk. * Tab UI polish * Get rid of max window error alert. Update tabs tray dialog * Fix rebase issue * Clone WidgetPlacement before sending to VR render thread to prevent concurrent access. (#2038) * Force view redraw when showing the awesome bar (#2050) * Import l10n. (#2060) * Fix long press menu highlight state. Fixes #2047 (#2056) * Fix potential title shown in new tab button when view is reused (#2053) * Import l10n. (#2063) * Make RootWidget focus more reliable. Fixes #2055. (#2058) * Import l10n. (#2065) * FxA (#1973) * Combined PR: FxA+Sync+Send Tab integration & Bookmarks navigation (#1417) * Closes #1395: Ability to navigate in and out of folders * Closes #1395: Add "Desktop Bookmarks" virtual folder when at the top level * Closes #717: FxA, Sync and Send Tab integrations This PR integrates FxA account manager and adds just enough code to allow signing-in via settings, signing out, synchronizing bookmarks and receiving tabs sent from other Firefox devices. TODO: - bookmarks UI needs folder support - better account management UI, currently there are just sign-in/sign-out buttons - megazord configuration? * Notify any BookmarkStore listeners of changes after sync is finished This makes sure we see synced bookmarks in the library right after signing-in. * Add history storage and configure it to be synchronized * Rebase fixes * Added support for Account settings and history/bookmarks updates * Added profile picture to the settings icon * Support for going back to sign in origin after login * Updated to AC v15 for the latest FxA API * Use SyncEnginesStorage to update SyncEngines * Rebase updates and improved library panels scroll performance * Folders support * Set production client Id * Remove unnecessary executePendingBindings * Refactoring * Always sync after signing in and remember sync status Some refactoring too * Style updates * Support responsive UI * Rebase updates * PR review updates #1 * PR review #2 * Rebase updates * Style updates from #2022 * Rebase fixes * Fixes tabs polling * Fix FxA onLoadRequest breaking background tabs (#2067) * Fix gaps in the fullscreen bar (#2066) * Import l10n. (#2070) * Private settings button fix (#2072) * Import l10n. (#2073) * Import l10n. (#2074) * Import l10n. (#2079) * Disable tray animations (#2082) * FxA related fixes (#2083) * Implement tab stacking (#2084) * Implement tab stacking * Set the stacked session parent inactive * Import l10n. (#2085) * Use user configuration to initialize session UA and viewport settings (#2069) * Correctly restore SessionSettings (#2080) * Receive FxA Tabs (#2068) * Receive FxA Tabs * Correctly update captured image on background tabs * Glean baseline pings integration. (stage 1) (#1854) * Attach the text input listener to the current active session (#2088) * Attach the text input listener to the current active session * Null check the attached window when detaching * Set prompt delegate when new stacked tab is created (#2087) * Hamburger menu (#2071) * Hamburger menu * Updated the menu icon tooltip * Show sent tab notification after sending a tab * Keep the devices list always synced * Handle devices list when not signed it * Override user agent for accounts.firefox.com * Change UA string to Desktop mode * Show a syncing text while devices are being refreshed * Remove user agent override from json * Add the FxA login url in a new tab * Fixed rebase issues * UA mode fixes * Update the accounts icon * Invalidated menu views after changing image drawable * Review fixes * Dissable gecko signon prompt and enbale about:config for debug builds (#2092) * Bump GV to 72.0.20191029093803 (#2094) * Capture tab snapshots when stacking sessions and opening the tabs dialog. (#2093) * Capture tab snapshots when stacking sessions and opening the tabs dialog. * Address review comments * Upgrade to Mozilla Android Component v.19. (#2089) * Upgrade to A-C v.19. * Glean configuration can't call its constructor after updating to AC19. * Add StickyTouchListener (#2096) * Updated Pop-up blocking flow (#2097) * Updated Pop-ups blocking flow * Fixed url bar icons * Added delay when opening allowed sessions * What's new dialog (#2091) * What's new dialog * Show the what's new dialog when sending tabs and not logged in * Fix what's new hide issues * Upgrade to AC 19.0.1 to get app_channel telemetry back. (#2104) * Import l10n. (#2105) * Whats new dialog fixes (#2101) * Whats new dialog fixes * Always select the first element after reloading the list * Remove `Unselect` copy paste menu action. (#2112) * Fixes misalignments in the url bar items (#2108) * Add open in tab menu item (#2106) Fixes issues with the library context menus * Fix wrongly displayed "Pause/Play" button. Take into account all windows to set CPU level based on video availability. (#2111) * Register to Window OnFullscreen changes instead of using GeckoSession.addContextListener (#2109) * Fix popup notification in curved mode (#2114) * Make the UI react faster to page loads (#2113) * Fix the transparent background when changing the button state (#2117) * Fixes issues after switching the tracking protection (#2125) * Fix tracking update issues * Add listeners to the new session after recreating * Displayed the context menu when double clicking on the URL bar (#2110) * Prevent voice search from getting stuck in a cancel loop (#2127) Fixes #1988 Fixes #1989 The search widget would call mMozillaSpeechService.cancel() after receiving a CANCELED status change and get stuck in a continuous loop. * Debounce popup block notification when blocking popups caused by back button (#2126) * Import l10n. (#2128) * Bump GV to 72.0.20191104094118 (#2135) * Bug 1574661 - update to use new TC deployment (#2086) * Bug 1574661 - update to use new TC deployment * Use new worker pool names (provisionerId / workerType) * Use new secret names * update links in README * URL bar polising (#2140) * Fix the hint private mode and remove unused resources * Increased url bar left padding * Setup session before updating the URL So we have the right session available when setting the URL * Hide the insecure icon from the url bar when the url text is empty * Add some end padding to the loading animation * Fix the top ui transparent background fix for private mode too (#2146) * Remove the ignore flag that prevented the update after deleting an item (#2145) * Show the header when the history is empty (#2148) * Fixed wrong thread ui call (#2154) * Audit promises exceptions (#2157) * Fix crash in onLoadRequest() (#2144) * Do not check parent sorting in invisible widgets (#2162) * Add logging to all accounts callbacks (#2166) * Fix missed clicks in menu items (#2165) * Clear private browsing tabs when private browsing is cleared. Fixes #2161 (#2167) * Do not save fullscreen state when paused. Fixes #1958 (#2169) * Queue History events while the session is inactive (#2163) * Queue History events while the session is inactive Revert new line * Better null checking and exception handling * Exception handling for real * Do not overlap History/Bookmarks FxA SyncStatus change operations (#2168) * Use Future instead of SyncListener to sync History/Bookmarks sync states (#2171) * Ensure that tab dialog and it's surface are invalidated before they are shown (#2179) * Fix sync status updates (#2173) * Refresh the sync status when opening the panels * Remove duplicated code * Better update of binding states Revert "Use Future instead of SyncListener to sync History/Bookmarks sync states (#2171)" This reverts commit 1e9e4a8. Revert "Revert "Use Future instead of SyncListener to sync History/Bookmarks sync states (#2171)"" This reverts commit 3299a6503e6bf1cffea6bd9fc7913a8da1af06e2. * Disable switches while syncing * Adds a spinner to the sync settings * Fix broken UI after restoring a Youtube session (#2181) * Avoid removing history items when updating history (#2180) * Fix resize save button color scheme (#2182) * Support v1 signing for Oculus Go APK (#2196) * Sync updates (#2183) * Update Sync UI * Do not add accounts listeners if Account UI is disabled * Do not debounce for explicit user sync requests * Fit empty history items in narrow mode * Fixes dismiss of the PopUps dialog (#2186) * Fix crash when string isEmpty (#2189) * Fix the text/link is wrongly pasted at the end of the URL from the Awesomebar (#2192) * Fix context menu still displayed after clicking the clear button (#2193) * Do not show context menu for videos (#2194) * Open the mobile bookmarks folder by default (#2164) * Avoid the FxA crash when reloading the success page after logout (#2204) * Hide search suggestions when focusing a different window (#2211) * Force update the hover button state after being disabled though bindings (#2210) * Fix switch state when syncing in the FxA panel (#2208) * Enqueue the voice start call to give time to the cancel to finish (#2212) * Enqueue the start call to give time to the cancel to finish * Increased the wait time for cancel to finish * Sort widgets by parent before updating all (#2213) * Do not show empty selection menu (#2216) * Fix Paste functionality in not available for empty input fields (#2225) * Import l10n. (#2231) * Hide library panels header if empty (#2221) * Show the scrollbar when popups view is shown (#2223) * Sync engines in case of a explicit sync (#2226) * Reset awesome bar scrollbar when showing (#2195) * Avoid opening the success tab if the account is existing/restored (#2232) * Restore voice search animation (#2234) * Hide the tabs send button until we have updated the devices (#2236) * Strings quarantine updates (#2172) * Strings quarantine updates * Fix typo * Import l10n. (#2240) * Fix FxA info dialog strings. Fixes #2239 (#2242) * Import l10n. (#2243) * Fix url bar focus issues (#2233) * Force URL bar to gain focus after a URL is loaded * Clear bookmarks button focus after binding is set * Import l10n. (#2251) * Import l10n. (#2252) * Hide bookmarks/history when selecting a different tab (#2190) * Import l10n. (#2253) * Bump FxR version to 7 (#2217) * Import l10n. (#2256) * WIP: Add DeepSpeech * Rebase fixes Co-authored-by: Manuel Martin <[email protected]> Co-authored-by: mozilla-l10n-automation-bot <[email protected]> Co-authored-by: Randall E. Barker <[email protected]> Co-authored-by: Imanol Fernandez <[email protected]> Co-authored-by: Daosheng Mu <[email protected]> Co-authored-by: Kearwood Gilbert <[email protected]> Co-authored-by: Philip Lamb <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.