Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No indication in UI of pages that have had new, unpublished translations land? #19

Open
stevejalim opened this issue Jul 31, 2024 · 0 comments
Assignees

Comments

@stevejalim
Copy link
Collaborator

(This may well be Driver Error on my part, but yesterday I noticed something while testing some other PRs.)

  1. Imagine en-US source page with localized versions (eg fr, de). All pages are published.
  2. Make some edits to the source page, publish and sync translations
  3. Run the management command that sends the job to Smartling
  4. Translation in Smartling is completed and the job published
  5. Run the management command again, which will now pull down the new translations
  6. Viewing the page tree (via the flyout explorer or the main browsing area), note that the localized pages are still marked as Live not Live+Draft.
  7. Viewing the live version of a localized page shows the older translated content
  8. Editing the localized page shows the new strings in place in the UI
  9. Previewing the localized page shows the new strings in the UI

Question: should the UI show Live+Draft when a translation lands from Smartling? Or is this deliberate behaviour (that can document)

I guess we could support that by saving a new revision of the relevant page(s) after the translation_imported Signal fires.

Equally, I think end-users (me) should wire up that translation_imported Signal to notify admins or moderators in some way, too

@stevejalim stevejalim changed the title No indication in UI of pages that have had new translations land? No indication in UI of pages that have had new, unpublished translations land? Jul 31, 2024
@stevejalim stevejalim self-assigned this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant