-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sccache for CTK 11.1 and properly track compilations in stats #2285
Open
trxcllnt
wants to merge
9
commits into
mozilla:main
Choose a base branch
from
trxcllnt:fix/cuda11.1-and-stats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+296
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since tools like CMake parse the output and expect to see client paths not dist-server paths
sorry, i don't know |
…rsed by inputs/outputs even if the preprocessor, cicc, and ptxas commands are out of order.
trxcllnt
force-pushed
the
fix/cuda11.1-and-stats
branch
from
November 14, 2024 01:27
30a1a7f
to
b1acd9d
Compare
This doesn't seem to be an issue with sccache. It appears clang can't compile its own preprocessor output: #!/usr/bin/env bash
# Basic CUDA example from https://godbolt.org/
cat <<EOF >/tmp/test.cu
__global__ void square(int* array, int n) {
int tid = blockDim.x * blockIdx.x + threadIdx.x;
if (tid < n)
array[tid] = array[tid] * array[tid];
}
EOF
# Preprocess
clang++ -x cuda -E --cuda-gpu-arch=sm_80 --cuda-path=/usr/local/cuda -Wno-unknown-cuda-version /tmp/test.cu > /tmp/test.cui
# Compile (fails)
clang++ -x cuda-cpp-output --cuda-gpu-arch=sm_80 --cuda-path=/usr/local/cuda -Wno-unknown-cuda-version -o /tmp/test.cu.o /tmp/test.cui |
cc: @robertmaynard for review |
robertmaynard
approved these changes
Nov 19, 2024
trxcllnt
force-pushed
the
fix/cuda11.1-and-stats
branch
from
November 22, 2024 21:40
3b0ae6c
to
5469482
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has some fixes I neglected to add to #2247.
nvcc
in CUDA toolkit v11.1 didn't add the-D__CUDA_ARCH_LIST__=
definition, so 5271494 expands the list of defines that indicate an nvcc host compiler invocation.--verbose
are never dist-compiled, since the verbose output is parsed by tools like CMake and must reflect the local toolchain.-Xclang
doesn't failQuestion for @sylvestre related to the last point -- do you know which bits of the clang toolchain (or CTK?) sccache should package when using clang as a device compiler? I am seeing errors like the following when attempting to dist-compile with ClangCUDA, but I'm not sure which files define the
__nvvm_*
symbols: