Skip to content
This repository has been archived by the owner on May 21, 2018. It is now read-only.

Hard to tell that it's loading/working on page load #70

Open
secretrobotron opened this issue Aug 10, 2016 · 6 comments
Open

Hard to tell that it's loading/working on page load #70

secretrobotron opened this issue Aug 10, 2016 · 6 comments
Labels

Comments

@secretrobotron
Copy link
Contributor

For example, on http://archive.org/pop/editor.html, it's difficult to know if anything is happening, because it's just a white page until assets/code/etc. are loaded.

@Nolski
Copy link
Contributor

Nolski commented Aug 16, 2016

The long loading seems to stem from require.js grabbing all of the html assets and such. This happens after the original browser page load. Perhaps throwing in a loading wheel overlay once PopcornEditor.init() is called and then remove it once the loaded event fires?

@secretrobotron
Copy link
Contributor Author

There was a way to make a dist version way back in the day that put everything into a big JS file, so you'd just have one request. I wonder if that's still supported somehow.

Nolski added a commit to Nolski/popcorn-editor that referenced this issue Aug 16, 2016
@benrito
Copy link
Collaborator

benrito commented Aug 25, 2016

@traceypooh should we try to merge this in?

@traceypooh
Copy link
Collaborator

sounds good to me!

@traceypooh
Copy link
Collaborator

is that #71
effectively?
i already felt it was fine to merge, but didn't have answer to @Nolski direct question in #71 ..

@benrito
Copy link
Collaborator

benrito commented Sep 16, 2016

Yeah -- @Nolski what do you think?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants