From 58c7b5b635e26d3d487c1ec626398f7aea3877a4 Mon Sep 17 00:00:00 2001
From: Jonas Jenwald <jonas.jenwald@gmail.com>
Date: Thu, 25 Jul 2024 12:26:31 +0200
Subject: [PATCH] Consistently dispatch events, if needed, when setting
 AppOptions

Currently we'll only dispatch events, for the options that support it, when updating preferences. Since this could potentially lead to inconsistent behaviour, let's avoid any future surprises by *always* dispatching events regardless of how the relevant option is being changed.

Obviously we should then also dispatch events in `AppOptions.set`, and to avoid adding even more duplicated code this method is changed into a wrapper for `AppOptions.setAll`.
While this is technically a tiny bit less efficient I don't think it matters in practice, since outside of development- and debug-mode `AppOptions.set` is barely used.
---
 web/app_options.js | 30 ++++++++++--------------------
 1 file changed, 10 insertions(+), 20 deletions(-)

diff --git a/web/app_options.js b/web/app_options.js
index 7b685ff2841ef..a4fe7105a9a1d 100644
--- a/web/app_options.js
+++ b/web/app_options.js
@@ -571,18 +571,7 @@ class AppOptions {
   }
 
   static set(name, value) {
-    const defaultOpt = defaultOptions[name];
-
-    if (
-      !defaultOpt ||
-      !(
-        typeof value === typeof defaultOpt.value ||
-        Type[(typeof value).toUpperCase()] & defaultOpt.type
-      )
-    ) {
-      return;
-    }
-    userOptions.set(name, value);
+    this.setAll({ [name]: value });
   }
 
   static setAll(options, prefs = false) {
@@ -601,15 +590,16 @@ class AppOptions {
       ) {
         continue;
       }
-      if (prefs) {
-        const { kind } = defaultOpt;
+      const { kind } = defaultOpt;
 
-        if (!(kind & OptionKind.BROWSER || kind & OptionKind.PREFERENCE)) {
-          continue;
-        }
-        if (this.eventBus && kind & OptionKind.EVENT_DISPATCH) {
-          (events ||= new Map()).set(name, userOpt);
-        }
+      if (
+        prefs &&
+        !(kind & OptionKind.BROWSER || kind & OptionKind.PREFERENCE)
+      ) {
+        continue;
+      }
+      if (this.eventBus && kind & OptionKind.EVENT_DISPATCH) {
+        (events ||= new Map()).set(name, userOpt);
       }
       userOptions.set(name, userOpt);
     }