You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 13, 2023. It is now read-only.
If you try to open more databases than an environment is configured to support, then lmdb-rs panics (with a DbsFull error). It should return an error instead.
And that seems true in general as well: when an error occurs, rather than panicking—which the consumer may or may not want—return an error (i.e. a Result<Error>), and let the consumer decide what to do with it (handle it, panic, etc.).
If you try to open more databases than an environment is configured to support, then lmdb-rs panics (with a DbsFull error). It should return an error instead.
And that seems true in general as well: when an error occurs, rather than panicking—which the consumer may or may not want—return an error (i.e. a Result<Error>), and let the consumer decide what to do with it (handle it, panic, etc.).
Upstream has issues for other panics, like danburkert#13, danburkert#27, danburkert#31, and danburkert#33; the first of which suggests that @danburkert would be amenable to returning a Result instead of panicking (at least in that case).
The text was updated successfully, but these errors were encountered: