feat(phone): Add removePhoneNumber to RecoveryPhoneService
#18035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschom
reviewed
Nov 19, 2024
| mockRecoveryPhoneManager.removePhoneNumber.mockRejectedValueOnce( | ||
| new RecoveryNumberNotExistsError(uid) | ||
| ); | ||
| expect(service.removePhoneNumber(uid)).rejects.toThrow(); |
There was a problem hiding this comment.
tiny nit, check that it throws a RecoveryNumberNotExistsError and not a different error.
dschom
reviewed
Nov 19, 2024
| * Remove phone number from an account. Each user can only have one associated | ||
| * phone number. | ||
| * | ||
| * @param uid |
There was a problem hiding this comment.
Document what uid is. (This is just for consistency... we all know what it is ;p)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
This pull request
removePhoneNumber, which throws error if nothing was removedIssue that this pull request solves
Closes: https://mozilla-hub.atlassian.net/browse/FXA-10349
Checklist