From 5cd1c219467d07959168610d2ab96969f134a401 Mon Sep 17 00:00:00 2001 From: Mathieu Leplatre Date: Tue, 1 Feb 2022 15:34:16 +0100 Subject: [PATCH] Fix backport records behaviour with group check setting (#1384) --- commands/backport_records.py | 2 -- tests/test_backport_records.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/commands/backport_records.py b/commands/backport_records.py index fd330c02..fcf6ec68 100644 --- a/commands/backport_records.py +++ b/commands/backport_records.py @@ -134,8 +134,6 @@ def backport_records(event, context, **kwargs): has_autoapproval = not signed_dest[0].get( "to_review_enabled", signer_config["to_review_enabled"] - ) and not signed_dest[0].get( - "group_check_enabled", signer_config["group_check_enabled"] ) if has_autoapproval: # Approve the changes. diff --git a/tests/test_backport_records.py b/tests/test_backport_records.py index 3268ae70..0b4c15fa 100644 --- a/tests/test_backport_records.py +++ b/tests/test_backport_records.py @@ -193,7 +193,7 @@ def test_pending_changes(self): "capabilities": { "signer": { "to_review_enabled": False, - "group_check_enabled": False, + "group_check_enabled": True, "resources": [ { "source": {