Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oic and Flask-pyoidc dependencies #341

Open
ccooper opened this issue Dec 7, 2020 · 1 comment · Fixed by #345
Open

Update oic and Flask-pyoidc dependencies #341

ccooper opened this issue Dec 7, 2020 · 1 comment · Fixed by #345

Comments

@ccooper
Copy link
Contributor

ccooper commented Dec 7, 2020

Renovate tried to take care of this in #339, but the pinned Flask-pyoidc version requires oic 0.9.1.0.

I'd suggest moving back to the origin from the pinned Flask-pyoidc version at the same time. The pinned version only seems to have formatting and docstring changes. However, the root Flask-pyoidc module is multiple versions ahead, so this will involve more work to update.

AFAICT, the biggest change will be in how we call OIDCAuthentication. The class now accepts (potentially) multiple providers, so we'll need to pass that in. Example is here.

@ccooper ccooper changed the title Update oic abd Flask-pyoidc dependencies Update oic and Flask-pyoidc dependencies Dec 7, 2020
@ccooper ccooper reopened this Dec 14, 2020
@ccooper
Copy link
Contributor Author

ccooper commented Dec 14, 2020

Sigh, this still erroring out while authenticating in prod. It is not straightforward, and the test coverage is abysmal. I'm going to stop messing with something as important as auth and leave this to someone else after I revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant