You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a rather large effort but I would be willing to work with you to make it happen.
Unlike the unit tests in the lua_sandbox which are quite comprehensive the unit tests in Hindsight are just place holders (they only test the configuration code). Currently all testing is performed manually at the integration level with hundreds of setups, data sets, and plugins. In general each setup tests a specific system behavior and then the internals (queues, checkpoints, states, stats) are inspected. The final validation is performed by running the latest version in parallel with our production infrastructure and comparing the performance and output. Most of the time incremental changes are made and only a small subset of tests need to be run manually. Unfortunately adding Windows support will require a full regression on every platform and a better solution would have to be put in place at that time.
As for the actual code changes; since Hindsight is a basically just threaded lua_sandbox manager (and even with C11 threading is still not fully supported/portable) it would be better to abstract it out. I was thinking about something like this https://github.com/tinycthread/tinycthread. With threading/synchronization abstracted out that still leaves inotify and some signal work.
can add windows support, I port it to windows, but it is test fail, can merge it after test is pass.
https://github.com/runner-mei/hindsight
The text was updated successfully, but these errors were encountered: