Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup checkout cache for code review production hook #159

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

La0
Copy link
Contributor

@La0 La0 commented Nov 4, 2024

This is the same patch as #32 + #39 to enable a new Taskcluster cache code-review-production-checkout for the code review production hook (using docker-worker).

Copy link
Contributor

@ahal ahal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the check failures are unrelated to your PR (caused by branch on hgmo changing levels). We can land your PR in the meantime, but it won't deploy until I resolve that.

@La0
Copy link
Contributor Author

La0 commented Nov 7, 2024

Please do not merge nor apply this patch yet, as we want to ship another important change before that one.

@La0
Copy link
Contributor Author

La0 commented Nov 26, 2024

@ahal This is now ready for deployment. I just rebased it to get CI passing

@La0 La0 requested a review from ahal November 27, 2024 07:55
@ahal ahal merged commit e14efdd into mozilla-releng:main Nov 28, 2024
8 checks passed
bhearsum added a commit to bhearsum/fxci-config that referenced this pull request Nov 29, 2024
According to Aryx:
> It causes issues (every exist detected by reviewbot gets reported as new, even preexisting ones)
@bhearsum
Copy link
Contributor

FYI: this is getting reverted in #193. According to @Archaeopteryx:

It causes issues (every exist detected by reviewbot gets reported as new, even preexisting ones)

bhearsum added a commit that referenced this pull request Nov 29, 2024
According to Aryx:
> It causes issues (every exist detected by reviewbot gets reported as new, even preexisting ones)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants