Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1675625 - Refactor error handing in Mojolicious to allow for native mojo code to something other than Bugzilla::Error #1655

Merged
merged 41 commits into from
Nov 30, 2020

Conversation

dklawren
Copy link
Collaborator

No description provided.

dklawren and others added 30 commits January 17, 2020 15:22
* upstream/master:
  Bug 1611257 - Bugmail is being filtered incorrectly since this morning's BMO deployment
  Bumped version to 20200117.1
* upstream/master:
  Bump version to 20200123.1
* upstream/master:
  Bump version to 20200211.1
  Bug 1612287 - Issue with negation operator in query search
  Bug 1611494 - Bugzilla custom email headers are getting mashed together
  Bug 1611281 - Double-escaping of '<' in code areas
  no bug - Add syntax for dot accessors of component props
  no bug - Fix Selenium tests for #1362
  Bug 1556727 - Replace “Email sent to” message with a toast notification
  Bug 1613686 - Improper encoding of content-type, content-transfer-encoding for security reports causes content to not be displayed properly
  no bug - Docker development environent and documentation changes.
* upstream/master:
  Bump version to 20200225.1
  Bug 1472757 - Comment field empty after clicking "go back page"
  Bug 1599865 - Bug description is erased during page load, leading to dataloss during Firefox session restore
  Bug 1237874 - File size unit always plural: "1 bytes"
  Bug 1612290 - Provide self-service UI for users to reactivate their account after being disabled due to bouncing
  Bug 1591549 - Hide bugs in dependencies and regression fields from users without access
  Bug 1617358 - Remove extra slash in mydashboard.html.tmpl
* upstream/master:
  Revert "Bug 1612290 - Provide self-service UI for users to reactivate their account after being disabled due to bouncing"
* upstream/master:
  Bump version to 20200226.1
  Bug 1612290 - Provide self-service UI for users to reactivate their account after being disabled due to bouncing (schema only)
  Bug 1614634 - 13 hours ago was not "1 day ago"
* upstream/master:
  Bug 1619361 - Update Reps Application Form
  Bump version to 20200226.2
  Bug 1612290 - Provide self-service UI for users to reactivate their account after being disabled due to bouncing
* upstream/master:
  Bug 1619609 - Update /rest/whoami to return group membership, and support authenticating with a Phabricator conduit token
  Bug 1620452 - secbugs report should be updated to allow emailing to multiple addresses
* upstream/master:
  no bug - Update VS Code tasks with Docker commands
  Bug 1605761 - It's not clear at all that you need to hit -enter- to save a comment tag
  Bug 1620236 - Comments on submitted bugs are re-populated if user chooses to show next bug in my list after changing a bug
* upstream/master:
  Bump version to 20200309.1
* upstream/master:
  Bug 1344094 - Add a link to a wiki.mozilla.org page describing how to request a keyword
  Bug 1622956 - Update contact URL and Address
  Bug 1621278 - Make bug IDs on search results proper bug links
  Bug 1621160 - First row of stagger column headers will be hidden when table header becomes sticky
  Bug 1621662 - Remove option for using Vagrant for BMO development and support Docker as primary method
* upstream/master:
  Bug 849902 - My dashboard refreshes itself
  Bug 1623727 - Graphviz needs to be installed in bmo-slim base container to allow showdependencygraph.cgi to work properly
* upstream/master:
  Bug 1628592 - Always display Severity field (#1549)
  Bug 1202669 - UX correction for change password and email
  Bug 1628467 - Button to stop auto-refresh in My dashboard
  Bug 1627601 - Copy Summary function doesn’t work properly if the bug summary contains HTML tags
  Bug 1626543 - Some fields on enter bug page do not have associated labels
  Bug 1622311 - For security bugs, link the security issue banner to https://wiki.mozilla.org/Security/Bug_Approval_Process
  Bump version to 20200401.1
  Bug 1410994 - Add utility for mass-disabling stale accounts
  Bug 1183759 :  Keyword suggestions should not show keywords which have been already selected
  Bug 1370492 - Assigned to you shows bugs priority in My dashboard
  no bug - update to 2.1 for CircleCI pipelines
* upstream/master:
  Bug 1632624 - When adding vars to the fields data that is logged to stack driver, convert to a JSON string
  no bug - Update docker mysql config to 64M for max_allowed_packet.
  Bug 1632038 - Remove number of people from bug update toast notification
  Bug 1631971 - Adds link to Matrix in README
  Bug 1631051-Store current configuration of auto refresh button in My Dashboard
  Bumped version to 20200416.2
  Bumped version to 20200416.1
  Bug 1588221 - Update current s3 storage controller to only upload attachments over a certain size
  Bug 1629648 - Remove the data science bug request icon from the Bugzilla homepage (#1550)
* upstream/master:
  Bug 1633848 - Fix possible areas where memory leak can occur in the PhabBugz daemon code
  Bug 1632994 - [Bugzilla.App] Can't use an undefined value as a subroutine reference at /app/Bugzilla/Error.pm line 94
* upstream/master:
  Bumped version to 20200504.1
  Bug 1635148 - Recent changes to add support for attachments in S3 caused a memory leak in the phabbugz feed daemon
  Bumped version to 20200429.1
  Bug 1623009 - Long password denial of service in bugzilla.mozilla.org
* upstream/master:
  Bug 1633846 - Enable retries for uploading attachments to S3 when an error occurs
* upstream/master:
  Bug 1639311 - Attaching a file with emojis breaks them
  Bug 1638022 - Phabbugz should not try to set needs-review when the revision is closed or abandoned
  Bumped version to 20200511.1
  Bug 1635332 - [SECURITY] Upgrade Mojolicous to 8.42
  Bug 1594066 - reproducible "Can't use ARRAY(0x17340610) as a field name." when Custom Search used
  Bug 1634342 - change links for security approval documents to source docs (#1564)
  Bug 1636549 Guided Bug Form incorrect severity
* upstream/master:
  Bug 1643821 - Add code to generate_conduit_data.pl to create an oauth2 client for Phabricator when used for development
  Bumped version to 20200603.1
  Bug 1642654 - Add ability for users to reactivate their own account when disabled from inactivity
  Bug 1641117 - Add Sentry to the list of See Also URLs.
  Bug 1641897 - Cleanup old severity values in custom forms and other places
  Bug 1641249 - Enable the crash signature field for the Focus and Fenix Stability components
  Bumped version to 20200526.1
  Bug 1639902 - Fix `Use of uninitialized value in string eq at /app/Bugzilla/Bug.pm line 4674`
  Bug 1639903 - Fix `Use of uninitialized value in pattern match (m//) at /app/Bugzilla/App.pm line 71`
* upstream/master:
  no bug - fix broken build script when no new commits to master since last prod deploy
  Bumped version to 20200624.1
  Bug 1646559 - Phabricator to BMO OAuth2 authentication fails to work properly due to CSP protections
  Bug 1645455 - Can't attach some text, 500 internal server error
  no bug - Figuring out proper Docker versions
  no bug - Fixed docker version for build speedup and enabled docker layer caching.
  no bug - Some speed up for docker image build for each job
* upstream/master:
  no bug - Fix build data script to help find the Mozilla CA cert
  no bug - Updated tasks.json to include some admin tasks
  Bug 1645768 - Please add 'See Also' support for GitLab
  no bug - remove warning "Odd number of elements"
* upstream/master:
  Bug 1535000 - Allow anyone with edit-comments to edit any bug's comment 0
  Bug 1651591 - remove preloading of fonts and ga; r=dkl
* upstream/master: (21 commits)
  Bug 1658846 - Allow users to enable and disable their webhooks
  no bug - Show Bounty Attachments to the Bug Reporter
  Bug 1657778 - Offer link to Bugzilla for filing security issues in Fenix and iOS
  Bug 1656609: Make <html> the scrolling element
  Bug 1658317 - Make scopes more descriptive and user friendly when authenticating to BMO using OAuth2
  Bug 1649841 - Include data-review? requests in notification count
  Bug 1659177 - Replace mozillians.org with people.mozilla.org in Reps Mentorship Form
  Bug 1588661 - Design for Webhooks
  Bug 1658622 - "product responsibilities" on editusers should include Triage Owner
  Bug 1657542 - During recent bmo deployment, emails were delivered to a file instead of SES which caused interruption of email service
  Bumped version to 20200805.1
  no bug - Updated docker-compose.test.yml for mysql settings in CircleCI environment.
  no bug - Use standard docker mysql for docker-compose instead of bmo-mysql
  Bug 1655808: send users in guided bug flow to GitHub for Android and iOS bug reports (#1600)
  Bug 1654370 - Remove remaining code that references Firefox OS from BMO code base
  Bug 1654456 - needinfo? request email enhancements (#1594)
  Bug 1643526 - Attachment comments don't render markdown, but their preview does
  Bumped version to 20200723.1
  Bug 1647642 - when commenting on patch or reviewing one, bugzilla clears other (review, ui-review) flags
  Bumped version 20200722.1
  ...
* upstream/master:
  Bumped version to 20200828.1
  Bug 1658845 - Allow users to see their own queue for their webhooks
* upstream/master:
  Bug 1664896 - checksetup.pl error when updating oath2_scope table to add detailed scope descriptions
  Bug 1656609 - Make <html> the scrolling element
  Bug 1661042 - Add a new table profile_iam to contain mappings between BMO accounts and LDAP accounts (code)
  Bumped version to 20200910.1
  Revert "Bug 1656609: Make <html> the scrolling element"
  Bug 1661042 - Add a new table profile_iam to contain mappings between BMO accounts and LDAP accounts (schema-only)
  Bug 1658841 - Webhooks should include comments added to a bug
  Bumper version to 20200908.1
  Bug 1662747 - Version number not visible in bug query results because of Long version numbers
* upstream/master:
  Bug 1670574 - The lightbox close button should be visible.
  Bug 1670092 - Update CircleCI configuration for BMO to follow new guidelines for downloading Docker Hub images
  Bug 1669755 - Email address changes are not being stored on profiles activity for some reason
  Bug 1669877 - Can't revert "Never email me about this bug"
  Bug 1665646 - Make it clear when a bug's description (comment 0) has multiple authors
  Bug 1669330 - Should not be possible to override bug type requirement when submitting a bug using API
  Bumped version to 20201001.1
  Bug 1668439 - fix lightbox image height when page is scrolled
  Bug 1668308 - Unauthenticated searches can generate massive cookies
  Bumped version to 20200928.1
  Bug 1667321 - remove hardcoded date ranges from Release Tracking Report
  Bug 1667201 - Change Reps Budget and Swag Form from Reps Portal to Community Portal
  Bug 1666917 - Remove code from PhabBugz extension dealing with auth delegation since it is no longer used
  Bug 1666292 - fix new comments indicator
  Bug 1665891 - fix lightbox scrolling
  Bug 1665916 - Remove block severity from blocklist bug creation template
  Bumped version to 20200916.1
* upstream/master:
  Bumped version to 20201014.1
  Bug 1670980 - Update Web API docs for creating bugs, rep_platform should be platform in example JSON
* upstream/master:
  Bug 1670319 - Allow use of OAuth2 bearer token as authentication for API calls same as API keys
  Bug 1671732 - Allow "See Also" field to link to github.com project security advisories
  Bug 1671135 - enable crash signature field for Remote Protocol product
* upstream/master:
  Bug 1673064 - BMO phabbugz server errors when a revision has a package owner set as a reviewer
* upstream/master:
  Bug 1673348 - request for possibility to prevent auto-assignment of bug to author of submitted patch if bug is leave-open or only disables tests
  Bug 1674166 - Note that created bugs will be private for the blocklist form
  Bug 1670319 - Allow use of OAuth2 bearer token as authentication for API calls same as API keys
  Bumped version to 20201027.2
  Revert "Bug 1670319 - Allow use of OAuth2 bearer token as authentication for API calls same as API keys"
  Revert "Bug 1669755 - Email address changes are not being stored on profiles activity for some reason"
  Bumped version to 20201027.1
* upstream/master:
  Bug 1622867 - Add an equivalent to `/latest/configuration` to the REST api
  Bug 1675466 - update link to intermittent failures view after treeherder changes
- Updated oauth2 client UI to use new error helpers
@dklawren dklawren requested a review from globau November 10, 2020 16:03
@dklawren dklawren changed the title Bug 1675625 - Refactor error handing in Mojolicious to allow for native mojo code to use Bugzilla::Error Bug 1675625 - Refactor error handing in Mojolicious to allow for native mojo code to something other than Bugzilla::Error Nov 10, 2020
Copy link
Collaborator

@globau globau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to update the routes in Bugzilla/API/V1/Teams.pm.

Bugzilla/App/API.pm Outdated Show resolved Hide resolved
Bugzilla/API/V1/User.pm Outdated Show resolved Hide resolved
* upstream/master:
  Bumped version to 20201117.1 (#1662)
  Bug 1673948 - Add "Team Name" as a search column (fixed API methods)
  Bug 1675075 - [Webhooks] Update all JSON data to be more consistent and update documentation to match
  no bug - Add .vtags to the .gitignore file
  Bumped version to 20201116.1 (#1660)
  Bug 1676877 - With recent changes to the Mojo REST endpoints, we need to disallow using cookies for auth when using API
  Bug 1673948 - Add "Team Name" as a search column
…into mojo-error-handling

* 'mojo-error-handling' of https://github.com/dklawren/bmo:
  - Refactoring to allow setting USAGE_MODE_REST for API error reporting
  - Fixed an issue with oauth2 clients and selecting multiple scopes - Updated oauth2 client UI to use new error helpers
  Bug 1675625 - Refactor error handing in Mojolicious to allow for native mojo code to use Bugzilla::Error
@dklawren dklawren requested a review from globau November 18, 2020 16:34
@dklawren dklawren requested review from globau and removed request for globau November 30, 2020 15:32
@dklawren dklawren merged commit ac77615 into mozilla-bteam:master Nov 30, 2020
@dklawren dklawren deleted the mojo-error-handling branch November 30, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants