-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comparison view should allow comparing strings across any repositories #320
Comments
Would a checkbox on the main search view for strings to search on all repositories at once work for you? |
I don't know where the that checkbox would be displayed and I'm not sure I fully understand what you mean. As a user I'm fine with anything that allows me to have a cross-repo view of strings. |
If you look at the main view, the search is per repository, my idea would be to either have a 'all repositories' option in the select box or a checkbox at the side of the select box with this same purpose. |
Julen is asking for "comparison view" involving all repositories, not a search. |
I understood his question, that's why I am proposing an alternative because we can't compare keys between Gaia and Desktop. I think my suggestion solves his use case but he should confirm. |
If you create a hash map of source strings, the comparison view should be possible and it wouldn't be expensive to query. But an All repositories search would work fine I believe. Ideally users should be able to selectively filter the repositories displayed in the results. |
I think I would tend towards an 'all repositories' option because Rimas asked for it last month so it may solve more use cases. Filtering per repository as we do now per folder is also probably feasible, we should make sure we don't turn the UI into Mozilla Suite prefs panel though :) |
I am working on the "all repositories" search option. |
Thank you @pascalchevrel, much appreciated! |
* New search class with a fluent interface * Removed "wildcard" search option from main view
* New search class with a fluent interface
Issues #320: move all our regex logic into a unit tested class
* New search class with a fluent interface * Removed "wildcard" search option from main view
* New search class with a fluent interface * Removed "wildcard" search option from main view
The comparison view currently only allows comparing strings across grouped repositories, i.e. Gaia on the one hand (
gaia-l10n
,gaia-vxy
), and the rest on the other hand (central
,aurora
,beta
,release
).Since some strings that have already been localized in the products are being reused in Gaia (I can think of network-related strings, This address is restricted for instance), it'd be great being able to compare strings across any repositories, so I could see how a string has been localized in
aurora
andgaia-vxy
repositories.The text was updated successfully, but these errors were encountered: