From 238795328e015adc3630378c9e99a083b89e880a Mon Sep 17 00:00:00 2001
From: Francesco Lodolo <flod@lodolo.net>
Date: Tue, 17 Sep 2024 09:04:25 +0200
Subject: [PATCH] Don't use search_translations_only for Pontoon links (#1041)

---
 app/classes/Transvision/ShowResults.php |  2 +-
 tests/units/Transvision/ShowResults.php | 20 ++++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/app/classes/Transvision/ShowResults.php b/app/classes/Transvision/ShowResults.php
index b72ec885..bc0dbfde 100644
--- a/app/classes/Transvision/ShowResults.php
+++ b/app/classes/Transvision/ShowResults.php
@@ -373,7 +373,7 @@ public static function getEditLink($tool, $repo, $key, $text, $locale)
             }
         }
 
-        $edit_link = "https://pontoon.mozilla.org/{$locale}/{$project_name}/{$resource_path}?search_identifiers=true&search_translations_only=true&search={$search_key}";
+        $edit_link = "https://pontoon.mozilla.org/{$locale}/{$project_name}/{$resource_path}?search_identifiers=true&search={$search_key}";
 
         return "&nbsp;<a class='edit_link' target='_blank' href='{$edit_link}'>&lt;edit in {$tool_name}&gt;</a>";
     }
diff --git a/tests/units/Transvision/ShowResults.php b/tests/units/Transvision/ShowResults.php
index 9c87b4f6..05350152 100644
--- a/tests/units/Transvision/ShowResults.php
+++ b/tests/units/Transvision/ShowResults.php
@@ -458,7 +458,7 @@ public function getEditLinkDP()
                 'browser/chrome/browser/browser.properties:webextPerms.hostDescription.allUrls',
                 'test',
                 'fr',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/chrome/browser/browser.properties?search_identifiers=true&search_translations_only=true&search=webextPerms.hostDescription.allUrls'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/chrome/browser/browser.properties?search_identifiers=true&search=webextPerms.hostDescription.allUrls'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -466,7 +466,7 @@ public function getEditLinkDP()
                 'calendar/chrome/calendar/calendar.dtd:calendar.calendar.label',
                 'test',
                 'fr',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/calendar/chrome/calendar/calendar.dtd?search_identifiers=true&search_translations_only=true&search=calendar.calendar.label'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/calendar/chrome/calendar/calendar.dtd?search_identifiers=true&search=calendar.calendar.label'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -474,7 +474,7 @@ public function getEditLinkDP()
                 'chat/commands.properties:dnd',
                 'test',
                 'fr',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/chat/commands.properties?search_identifiers=true&search_translations_only=true&search=dnd'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/thunderbird/chat/commands.properties?search_identifiers=true&search=dnd'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -482,7 +482,7 @@ public function getEditLinkDP()
                 'browser/browser/preferences/main.ftl:default-content-process-count.label',
                 'test',
                 'fr',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/browser/preferences/main.ftl?search_identifiers=true&search_translations_only=true&search=default-content-process-count'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/fr/firefox/browser/browser/preferences/main.ftl?search_identifiers=true&search=default-content-process-count'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -498,7 +498,7 @@ public function getEditLinkDP()
                 'mail/chrome/messenger/addressbook/abContactsPanel.dtd:ccButton.label',
                 'test',
                 'de',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/de/thunderbird/mail/chrome/messenger/addressbook/abContactsPanel.dtd?search_identifiers=true&search_translations_only=true&search=ccButton.label'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/de/thunderbird/mail/chrome/messenger/addressbook/abContactsPanel.dtd?search_identifiers=true&search=ccButton.label'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -506,7 +506,7 @@ public function getEditLinkDP()
                 'suite/chrome/browser/taskbar.properties:taskbar.tasks.composeMessage.description',
                 'test',
                 'it',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/seamonkey/suite/chrome/browser/taskbar.properties?search_identifiers=true&search_translations_only=true&search=taskbar.tasks.composeMessage.description'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/seamonkey/suite/chrome/browser/taskbar.properties?search_identifiers=true&search=taskbar.tasks.composeMessage.description'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -514,7 +514,7 @@ public function getEditLinkDP()
                 'mozilla_org/en/banners/firefox-mobile.ftl:banner-firefox-mobile-get-android-title',
                 'test',
                 'it',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/mozillaorg/en/banners/firefox-mobile.ftl?search_identifiers=true&search_translations_only=true&search=banner-firefox-mobile-get-android-title'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/mozillaorg/en/banners/firefox-mobile.ftl?search_identifiers=true&search=banner-firefox-mobile-get-android-title'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -522,7 +522,7 @@ public function getEditLinkDP()
                 'android_l10n/mozilla-mobile/fenix/app/src/main/res/values/strings.xml:preference_experiments',
                 'test',
                 'it',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-android/mozilla-mobile/fenix/app/src/main/res/values/strings.xml?search_identifiers=true&search_translations_only=true&search=preference_experiments'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-android/mozilla-mobile/fenix/app/src/main/res/values/strings.xml?search_identifiers=true&search=preference_experiments'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -530,7 +530,7 @@ public function getEditLinkDP()
                 'firefox_ios/firefox-ios.xliff:4e0bc9d4',
                 'test',
                 'it',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search_translations_only=true&search=test'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search=test'>&lt;edit in Pontoon&gt;</a>",
             ],
             [
                 'pontoon',
@@ -555,7 +555,7 @@ public function getEditLinkDP()
                 'firefox_ios/firefox-ios.xliff:4e0bc9d4',
                 '%(test)',
                 'it',
-                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search_translations_only=true&search=%25%28test%29'>&lt;edit in Pontoon&gt;</a>",
+                "&nbsp;<a class='edit_link' target='_blank' href='https://pontoon.mozilla.org/it/firefox-for-ios/firefox-ios.xliff?search_identifiers=true&search=%25%28test%29'>&lt;edit in Pontoon&gt;</a>",
             ],
             // Test unknown tool
             [