Parse CN from DN using OpenSSL facilities #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use OpenSSL facilities to parse the CN from the DN. This allows to correctly parse certificates which have additional DN components after the CN, such as "emailAddress". The manual parsing included additional components following the CN as part of the common name, which in turn lead to DNS lookups for malformed domain names such as "www.example.com/[email protected]".
|
In my view, the behavior of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use OpenSSL facilities to parse the CN from the DN. This allows to
correctly parse certificates which have additional DN components after
the CN, such as "emailAddress". The manual parsing included additional
components following the CN as part of the common name, which in turn
lead to DNS lookups for malformed domain names such as
"www.example.com/emailAddress=[email protected]".
Fixes issue #12 reported by ju916