Feature/new oauth server name #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeljesus
reviewed
Oct 23, 2017
| @@ -61,6 +176,29 @@ const oAuthServerSchema = { | |||
| preserve_host: false, | |||
| listen_path: '', | |||
| upstream_url: '', | |||
| upstreams: { | |||
There was a problem hiding this comment.
If all upstreams schemas has the same structure we could declare one and reuse over the code, so we don't repeat
There was a problem hiding this comment.
totally agree, but here is one but:
in future, this schema, probably, will come from the server side...
rafaeljesus
reviewed
Oct 23, 2017
| @@ -31,6 +31,8 @@ class CorsPlugin extends PureComponent { | |||
| render() { | |||
| const { apiSchema, className, edit, name, handlePluginExclude, plugin, pluginName } = this.props; | |||
| const b = block(className); | |||
| console.error('nem_____', name); | |||
rafaeljesus
reviewed
Oct 23, 2017
| this.props.saveOAuthServer(this.props.location.pathname, values); | ||
| const transformedValues = transformFormValues(values, true); | ||
|
|
||
| this.props.saveOAuthServer(this.props.location.pathname, transformedValues); |
There was a problem hiding this comment.
function composition would be possible here too, if parameter order does not fit we could reorder it
There was a problem hiding this comment.
In this case, it would be a bit harder then it looks like at first. I'll investigate and make separate PR related to this case.
rafaeljesus
reviewed
Oct 23, 2017
| const createOptions = (list1, list2) => { | ||
| const combinedListOfUnitsAndLabels = R.zip(list1, list2); | ||
|
|
||
| return combinedListOfUnitsAndLabels.map(item => ({ |
There was a problem hiding this comment.
const asLabelValue = item => ({ label: item[1], value: item[0] })
return R.zip(list1, list2).map(asLabelValue)There was a problem hiding this comment.
Again my bad... this code is redundant here... 🔫
rafaeljesus
reviewed
Oct 23, 2017
| const createOptions = (list1, list2) => { | ||
| const combinedListOfUnitsAndLabels = R.zip(list1, list2); | ||
|
|
||
| return combinedListOfUnitsAndLabels.map(item => ({ |
|
👍 |
rafaeljesus
approved these changes
Oct 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.