Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added destroy method (Issue #8) #11

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

aaronstillwell
Copy link

Prompt is provided for deleting files when in interactive mode as per my discussion with @marksiemers

An accompanying spec will follow shortly

Copy link

@marksiemers marksiemers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if NOT in interactive mode, this won't prompt the user at all?

If that is the case, we had a mis-communication. I think no matter what, the user should be asked once to confirm that that want to delete all the files.

Optionally (if you want to do more work for this PR), Interactive mode will prompt once per file that will be deleted.

@aaronstillwell
Copy link
Author

@marksiemers understood, I'll follow up with a modification for the behaviour you've described + I'll resolve the failing CI build.

Also includes destroyed/skipped messages
@aaronstillwell
Copy link
Author

@marksiemers the behaviour implemented by this PR should now match your expectations. I'm still to follow up with a spec.

I believe the currently failing test is resolved by #10.

@faustinoaq
Copy link

Hi @mosop Does this still fix #8 ? 😅

@marksiemers
Copy link

@mosop - Can this be merged or closed?

I realize some conflicts will have to be resolved in order to merge, but if it's just going to be closed, no need to resolve them.

@drujensen
Copy link
Contributor

@aaronstillwell @marksiemers can you resolve the conflicts? I can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants