Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script.xbmc.subtitles.torec not part of script.xbmc.subtitles #3

Open
guysoft opened this issue May 3, 2013 · 2 comments
Open

script.xbmc.subtitles.torec not part of script.xbmc.subtitles #3

guysoft opened this issue May 3, 2013 · 2 comments

Comments

@guysoft
Copy link

guysoft commented May 3, 2013

Hey,
I took the liberty of merging this git repo with the global script.xbmc.subtitles repo.
This should really be developed alongside the addon and be pushed in to XBMC releases so everyone could enjoy it.

Here is the pull request:
amet/script.xbmc.subtitles#174
(note its a subtree merge, all the history is kept inside script.xbmc.subtitles)

Would value your input.

@guysoft
Copy link
Author

guysoft commented May 3, 2013

Ok, THIS PROJECT HAS BEEN MERGED IN TO script.xbmc.subtitles.

I suggest you all checkout the source there and use it, so we all remain in the same tree:
amet/script.xbmc.subtitles@32eedb8

@morsela
Copy link
Owner

morsela commented May 4, 2013

Actually I'm quite surprised as to your latest actions.
Open source or not - I do believe that an integration decision should be made by the code author (and not some random guy with "good intentions").
On the practical side - there are some viable causes as to why and when should this code be distributed - Torec site administrators' approval; supported systems testing, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants