From 4ab634b3f2cd59ad73d1b85f8f5413971c23a3fb Mon Sep 17 00:00:00 2001 From: Sergei Morozov Date: Tue, 13 Jun 2023 09:48:44 -0700 Subject: [PATCH] Remove the test that uses TestCase::getMockForAbstractClass() See: https://github.com/sebastianbergmann/phpunit/issues/5241 It covers a platform-specific use case in the base platform class, which is pointless. --- tests/Types/BinaryTest.php | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/tests/Types/BinaryTest.php b/tests/Types/BinaryTest.php index d95de474e0a..bdb4093c52b 100644 --- a/tests/Types/BinaryTest.php +++ b/tests/Types/BinaryTest.php @@ -35,39 +35,6 @@ public function testReturnsBindingType(): void self::assertSame(ParameterType::BINARY, $this->type->getBindingType()); } - /** - * @param mixed[][] $definition - * - * @dataProvider definitionProvider() - */ - public function testReturnsSQLDeclaration(array $definition, string $expectedDeclaration): void - { - $platform = $this->getMockForAbstractClass(AbstractPlatform::class); - self::assertSame($expectedDeclaration, $this->type->getSQLDeclaration($definition, $platform)); - } - - /** @return mixed[][] */ - public static function definitionProvider(): iterable - { - return [ - 'fixed-unspecified-length' => [ - ['fixed' => true], - 'BINARY', - ], - 'fixed-specified-length' => [ - [ - 'fixed' => true, - 'length' => 20, - ], - 'BINARY(20)', - ], - 'variable-length' => [ - ['length' => 20], - 'VARBINARY(20)', - ], - ]; - } - public function testBinaryNullConvertsToPHPValue(): void { self::assertNull($this->type->convertToPHPValue(null, $this->platform));