Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: softDelete() #68

Open
optmsp opened this issue Jan 2, 2022 · 0 comments
Open

Feature Request: softDelete() #68

optmsp opened this issue Jan 2, 2022 · 0 comments

Comments

@optmsp
Copy link

optmsp commented Jan 2, 2022

Unless I'm using this trait incorrectly, to use soft deletes we need to always use the method $model->deleteWithRelated(). The method $model->delete() continues to do a hard delete. While I like that $model->deleteWithRelated() recurses through children data to soft delete them as well as the parent, sometimes it would be nice to simply have a softDelete() instead of building an exception list for $skippedRelations.

Is that on the drawing board? Would you accept a PR with this method if not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant