From bd559e3e5a0748c19334ad94fa69d28ebb90d01f Mon Sep 17 00:00:00 2001
From: marco-ippolito <marcoippolito54@gmail.com>
Date: Mon, 29 Apr 2024 11:07:03 +0200
Subject: [PATCH] util: move util.isObject to eol
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PR-URL: https://github.com/nodejs/node/pull/52744
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 doc/api/deprecations.md    |  8 +++++---
 doc/api/util.md            | 30 ------------------------------
 lib/util.js                | 13 -------------
 test/parallel/test-util.js |  7 -------
 4 files changed, 5 insertions(+), 53 deletions(-)

diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
index 989e49408daa93..a2448ea270a3bf 100644
--- a/doc/api/deprecations.md
+++ b/doc/api/deprecations.md
@@ -1204,6 +1204,9 @@ The `util.isNumber()` API has been removed. Please use
 
 <!-- YAML
 changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/52744
+    description: End-of-Life deprecation.
   - version: v22.0.0
     pr-url: https://github.com/nodejs/node/pull/50488
     description: Runtime deprecation.
@@ -1219,9 +1222,9 @@ changes:
     description: Documentation-only deprecation.
 -->
 
-Type: Runtime
+Type: End-of-Life
 
-The [`util.isObject()`][] API is deprecated. Please use
+The `util.isObject()` API has been removed. Please use
 `arg && typeof arg === 'object'` instead.
 
 ### DEP0054: `util.isPrimitive()`
@@ -3805,7 +3808,6 @@ is deprecated to better align with recommendations per [NIST SP 800-38D][].
 [`util.isArray()`]: util.md#utilisarrayobject
 [`util.isError()`]: util.md#utiliserrorobject
 [`util.isFunction()`]: util.md#utilisfunctionobject
-[`util.isObject()`]: util.md#utilisobjectobject
 [`util.isPrimitive()`]: util.md#utilisprimitiveobject
 [`util.log()`]: util.md#utillogstring
 [`util.promisify`]: util.md#utilpromisifyoriginal
diff --git a/doc/api/util.md b/doc/api/util.md
index cbf56074bb9945..6fd5a824b43f8b 100644
--- a/doc/api/util.md
+++ b/doc/api/util.md
@@ -3045,36 +3045,6 @@ util.isFunction(Bar);
 // Returns: true
 ```
 
-### `util.isObject(object)`
-
-<!-- YAML
-added: v0.11.5
-deprecated: v4.0.0
--->
-
-> Stability: 0 - Deprecated:
-> Use `value !== null && typeof value === 'object'` instead.
-
-* `object` {any}
-* Returns: {boolean}
-
-Returns `true` if the given `object` is strictly an `Object` **and** not a
-`Function` (even though functions are objects in JavaScript).
-Otherwise, returns `false`.
-
-```js
-const util = require('node:util');
-
-util.isObject(5);
-// Returns: false
-util.isObject(null);
-// Returns: false
-util.isObject({});
-// Returns: true
-util.isObject(() => {});
-// Returns: false
-```
-
 ### `util.isPrimitive(object)`
 
 <!-- YAML
diff --git a/lib/util.js b/lib/util.js
index 1a7e4064c674bf..ae7429e1f5cfa6 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -90,15 +90,6 @@ function lazyAbortController() {
 
 let internalDeepEqual;
 
-/**
- * @deprecated since v4.0.0
- * @param {any} arg
- * @returns {a is NonNullable<object>}
- */
-function isObject(arg) {
-  return arg !== null && typeof arg === 'object';
-}
-
 /**
  * @deprecated since v4.0.0
  * @param {any} e
@@ -363,10 +354,6 @@ module.exports = {
     }
     return internalDeepEqual(a, b);
   },
-  isObject: deprecate(isObject,
-                      'The `util.isObject` API is deprecated. ' +
-                      'Please use `arg !== null && typeof arg === "object"` instead.',
-                      'DEP0053'),
   isDate: deprecate(types.isDate,
                     'The `util.isDate` API is deprecated.  Please use `arg instanceof Date` instead.',
                     'DEP0047'),
diff --git a/test/parallel/test-util.js b/test/parallel/test-util.js
index 70c9be81e96d6d..a0423c7605f65a 100644
--- a/test/parallel/test-util.js
+++ b/test/parallel/test-util.js
@@ -62,13 +62,6 @@ assert.strictEqual(util.isError({ name: 'Error', message: '' }), false);
 assert.strictEqual(util.isError([]), false);
 assert.strictEqual(util.isError({ __proto__: Error.prototype }), true);
 
-// isObject
-assert.strictEqual(util.isObject({}), true);
-assert.strictEqual(util.isObject([]), true);
-assert.strictEqual(util.isObject(new Number(3)), true);
-assert.strictEqual(util.isObject(Number(4)), false);
-assert.strictEqual(util.isObject(1), false);
-
 // isPrimitive
 assert.strictEqual(util.isPrimitive({}), false);
 assert.strictEqual(util.isPrimitive(new Error()), false);