Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension doesn't detect if the website changed #84

Open
rms5566 opened this issue Dec 2, 2019 · 3 comments
Open

Extension doesn't detect if the website changed #84

rms5566 opened this issue Dec 2, 2019 · 3 comments

Comments

@rms5566
Copy link

rms5566 commented Dec 2, 2019

Expected behavior

The Mooltipass Mini BLE should not ask to send the credentials of website github.com if I changed to a other website(https://gitlab.com/users/sign_in)(multiple tabs)

Actual behavior

If I go to https://github.com/login my Mooltipass Mini BLE ask to confirm my credentials. If I go to https://gitlab.com/users/sign_in without pressing the scroll wheel it still ask if I want to confirm the username and password for https://github.com/login.

Step by step guide to reproduce the problem

try to login to any website
don't press the scroll wheel to confirm the login.
change tab to another page with a login form
Mooltipass still ask to confirm the login credentials for the first website
Press the scroll wheel
credentials from first website are inserted into the login field from the second website
Mooltipass ask if I want to login with the credentials of the second website.

Browser extension

1.8.0 Firefox

Moolticute Version

v0.42.14-testing

Operating System

  • Windows 10 Enterprise 2016 LTSB

Mooltipass Device

  • The Mooltipass Mini BLE
@limpkin
Copy link
Contributor

limpkin commented Dec 2, 2019

Could you double check? I'm not able to reproduce....
If so, could you write a more detailed guide to reproduce this issue?

@rms5566
Copy link
Author

rms5566 commented Dec 2, 2019

I restarted my computer and used firefox with only two tabs. I couldn't reproduce it as well. But I was able to reproduce it with more tabs!

First you have to open more than 60 tabs in firefox. Multiple tabs include the same website/login form. The Mooltipass start asking to confirm the credentials. Don't press the scroll wheel! The credentials request stop after about 10-20 seconds and the next website is displayed on the Mooltipass. Don't press the scroll wheel! Now I click though some tabs again. Most tabs contain websites with a login form. After that I choose a website on my tab where I have multiple user accounts(credentials). The Mooltipass didn't ask to confirm the credentials because I wasn't responding earlier. I press F5 and the Mooltipass wants that I select a username. Don't select a user now! Go to another tab/website(https://github.com/login) and now press the scroll wheel. The Mooltipass now fill out the login form for the wrong website. After a short delay the Mooltipass start asking to confirm the credentials for other websites. Maybe I'm too fast and the extension/Mooltipass can't handle this?

@rms5566
Copy link
Author

rms5566 commented Dec 2, 2019

@limpkin I found the problem. It only takes 6 steps to reproduce.

  1. Start firefox.
  2. Open two common websites on different tabs.
  3. Go to the first website and wait until the Mooltipass wants you to confirm the credentials.
  4. Go to the second website and press F5 to reload the website.
  5. Press the scroll wheel.
  6. The Mooltipass insert the credentials for the first website on the second website.

This worked 10 out of 10 times for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants