Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grade core string deprecated in Moodle 3.11 #120

Open
logan-reynolds opened this issue Aug 15, 2021 · 1 comment
Open

Grade core string deprecated in Moodle 3.11 #120

logan-reynolds opened this issue Aug 15, 2021 · 1 comment

Comments

@logan-reynolds
Copy link

When doing basic operational tests with latest commit of mod_oublog on the MOODLE_39_STABLE branch (version 2020091401 release 3.9 r1) running against Moodle 3.11.2 with PHP 7.4, I'm seeing the following string deprecation warning when going to add an instance to course:

String [grade,core] is deprecated. Either you should no longer be using that string, or the string has been incorrectly deprecated, in which case you should report this as a bug. Please refer to https://docs.moodle.org/dev/String_deprecation

    line 394 of /lib/classes/string_manager_standard.php: call to debugging()
    line 7283 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
    line 180 of /mod/oublog/mod_form.php: call to get_string()
    line 214 of /lib/formslib.php: call to mod_oublog_mod_form->definition()
    line 130 of /course/moodleform_mod.php: call to moodleform->__construct()
    line 150 of /course/modedit.php: call to moodleform_mod->__construct()
@drobayo
Copy link

drobayo commented Oct 31, 2021

Maybe this can work here:
mod_form
Change
$mform->addElement('header', 'modstandardgrade', get_string('grade'));
with
$mform->addElement('header', 'modstandardgrade', get_string('gradenoun'));

Change:
mform->addElement('modgrade', 'grade', get_string('grade'));
with
mform->addElement('modgrade', 'grade', get_string('gradenoun'));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants