Fix thirdparty icon size in 4.4 courseindex drawer, resolves #755 #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christianwolters
force-pushed
the
issue-755
branch
from
15d57dc
to
0db00d3
Compare
|
Thank you very much for this fix, @christianwolters . |
abias
merged commit 2b5df1e
into
moodle-an-hochschulen:MOODLE_404_STABLE
0 of 6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides explicit width and height for icons in the courseindex drawer for Moodle 4.4.
As mentioned in the issue, this is needed if icons exceed a specific size as seen with some thridparty plugins.
To provide consitency with 4.4. styling, 24px were used as values.