Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: Add more static pages, solves #351. #353

Merged
merged 1 commit into from
Aug 19, 2023

Conversation

wa-bea
Copy link
Collaborator

@wa-bea wa-bea commented Aug 2, 2023

This patch adds five additional static pages:

  • About us
  • Offers
  • Generic page 1
  • Generic page 2
  • Generic page 3

@abias
Copy link
Member

abias commented Aug 19, 2023

Thank you very much @wa-bea for working on this PR!

Adding some more static pages makes sense. I agree with the addition of the about us and the offers page and the generic pages also make sense for installations who need even more pages without changing the Boost Union source code.

Your patch is spot-on.
I just rebased your PR onto the latest master and changed the order of the pages in the language pack, on the settings page and so on based on the order of the page links in the footnote and the footer.

As soon as the tests are green, I will merge the PR.

@abias abias self-requested a review August 19, 2023 10:34
abias
abias previously approved these changes Aug 19, 2023
@abias abias merged commit 8dc7e37 into moodle-an-hochschulen:master Aug 19, 2023
@wiebkemueller-hsh wiebkemueller-hsh added the documentation Something which improves or amends documentation label Sep 28, 2023
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Something which improves or amends documentation
Projects
Status: CLOSED
Development

Successfully merging this pull request may close these issues.

3 participants