Improvement: Fix more mustache linter warnings, solves #360. (#361)

moodle-an-hochschulen · Aug 20, 2023 · f5d5932 · f5d5932
1 parent 8dc7e37
commit f5d5932
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 14 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -6,6 +6,7 @@ Changes
 
 ### Unreleased
 
+* 2023-08-19 - Improvement: Fix more mustache linter warnings, solves #360.
 * 2023-08-02 - Improvement: Add 'aboutus', 'offers', 'page1', 'page2' and 'page3' static pages, solves #351.
 * 2023-08-19 - Bugfix: Fix unparsable example JSON in Mustache template, solves #348.
 * 2023-08-18 - Improvement: Add CSS and Scripts for local_och5p local_och5pcore to the theme renderer.

diff --git a/templates/course-hint-guestaccess.mustache b/templates/course-hint-guestaccess.mustache
@@ -37,7 +37,7 @@
         <div class="media-body align-self-center">
             {{#str}} showhintcourseguestaccessgeneral, theme_boost_union, { "role": "{{role}}" } {{/str}}
             {{#showselfenrollink}}
-                <br />{{#str}} showhintcourseguestaccesslink, theme_boost_union, { "url": "{{config.wwwroot}}/enrol/index.php?id={{courseid}}" } {{/str}}
+                <br>{{#str}} showhintcourseguestaccesslink, theme_boost_union, { "url": "{{config.wwwroot}}/enrol/index.php?id={{courseid}}" } {{/str}}
             {{/showselfenrollink}}
         </div>
     </div>

diff --git a/templates/course-hint-hidden.mustache b/templates/course-hint-hidden.mustache
@@ -35,7 +35,7 @@
         <div class="media-body align-self-center">
             {{#str}} showhintcoursehiddengeneral, theme_boost_union {{/str}}
             {{#showcoursesettingslink}}
-                <br />{{#str}} showhintcoursehiddensettingslink, theme_boost_union, { "url": "{{config.wwwroot}}/course/edit.php?id={{courseid}}" } {{/str}}
+                <br>{{#str}} showhintcoursehiddensettingslink, theme_boost_union, { "url": "{{config.wwwroot}}/course/edit.php?id={{courseid}}" } {{/str}}
             {{/showcoursesettingslink}}
         </div>
     </div>

diff --git a/templates/course-hint-selfenrol.mustache b/templates/course-hint-selfenrol.mustache
@@ -37,10 +37,10 @@
         <div class="media-body align-self-center">
             {{{selfenrolhintstart}}}
             {{#selfenrolinstances}}
-                <br />{{{.}}}
+                <br>{{{.}}}
             {{/selfenrolinstances}}
             {{#calltoaction}}
-                <br />{{#str}} showhintcourseselfenrolinstancecallforaction, theme_boost_union {{/str}}
+                <br>{{#str}} showhintcourseselfenrolinstancecallforaction, theme_boost_union {{/str}}
             {{/calltoaction}}
         </div>
     </div>

diff --git a/templates/course-hint-switchedrole.mustache b/templates/course-hint-switchedrole.mustache
@@ -36,7 +36,7 @@
         <div class="mr-3 icon-size-5"><i class="fa fa-exclamation-circle fa-3x"></i></div>
         <div class="media-body align-self-center">
             {{#str}} switchedroleto, theme_boost_union, { "role": "{{role}}" } {{/str}}
-            <br /><a href="{{{url}}}" class="switched-role-backlink">{{#str}} switchrolereturn, core {{/str}}</a>
+            <br><a href="{{{url}}}" class="switched-role-backlink">{{#str}} switchrolereturn, core {{/str}}</a>
         </div>
     </div>
 </div>
diff --git a/templates/settings-additionalresources-filelist.mustache b/templates/settings-additionalresources-filelist.mustache
@@ -44,9 +44,9 @@
                 {{{fileicon}}}
                 <div class="ml-2">
                     <h6 class="mb-0">{{filename}}</h6>
-                    <small>{{#str}}mimetype, tool_filetypes{{/str}}: {{filetype}}</small><br />
-                    <small>{{#str}}size, repository{{/str}}: {{filesize}}</small><br />
-                    <small>{{#str}}additionalresourcesfileurlpersistent, theme_boost_union{{/str}}: <a href="{{fileurlpersistent}}">{{fileurlpersistent}}</a></small><br />
+                    <small>{{#str}}mimetype, tool_filetypes{{/str}}: {{filetype}}</small><br>
+                    <small>{{#str}}size, repository{{/str}}: {{filesize}}</small><br>
+                    <small>{{#str}}additionalresourcesfileurlpersistent, theme_boost_union{{/str}}: <a href="{{fileurlpersistent}}">{{fileurlpersistent}}</a></small><br>
                     <small>{{#str}}additionalresourcesfileurlrevisioned, theme_boost_union{{/str}}: <a href="{{fileurlrevisioned}}">{{fileurlrevisioned}}</a></small>
                 </div>
             </div>

diff --git a/templates/settings-fontawesome-filelist.mustache b/templates/settings-fontawesome-filelist.mustache
@@ -55,7 +55,7 @@
                 {{^exists}}<span class="{{#mandatory}}text-danger{{/mandatory}}{{^mandatory}}text-muted{{/mandatory}}"><i class="fa fa-times-circle-o fa-3x fa-fw"></i></span>{{/exists}}
                 <div class="ml-3">
                     <h6 class="mb-0">{{filepath}}</h6>
-                    <small>{{description}}</small><br />
+                    <small>{{description}}</small><br>
                     {{#exists}}<small>{{#mandatory}}{{#str}}fontawesomelistmandatoryuploaded,theme_boost_union{{/str}}{{/mandatory}}{{^mandatory}}{{#str}}fontawesomelistoptionaluploaded,theme_boost_union{{/str}}{{/mandatory}}</small>{{/exists}}
                     {{^exists}}<small>{{#mandatory}}{{#str}}fontawesomelistmandatorymissing,theme_boost_union{{/str}}{{/mandatory}}{{^mandatory}}{{#str}}fontawesomelistoptionalmissing,theme_boost_union{{/str}}{{/mandatory}}</small>{{/exists}}
                 </div>

diff --git a/templates/settings-modicon-filelist.mustache b/templates/settings-modicon-filelist.mustache
@@ -55,20 +55,20 @@
                 <div class="ml-3">
                     <h6 class="mb-0">{{path}}</h6>
                     {{#mod}}
-                        <small>{{#str}}modiconactivity, theme_boost_union{{/str}}: {{mod}}</small><br />
-                        {{#moodle4}}<small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modicongtmoodle4, theme_boost_union{{/str}}</small><br />{{/moodle4}}
-                        {{#moodle3}}<small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modiconltmoodle311, theme_boost_union{{/str}}</small><br />{{/moodle3}}
+                        <small>{{#str}}modiconactivity, theme_boost_union{{/str}}: {{mod}}</small><br>
+                        {{#moodle4}}<small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modicongtmoodle4, theme_boost_union{{/str}}</small><br>{{/moodle4}}
+                        {{#moodle3}}<small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modiconltmoodle311, theme_boost_union{{/str}}</small><br>{{/moodle3}}
                         {{^invalidname}}
                             {{#moodle4}}<small>{{#str}}modiconsuccess4x, theme_boost_union, {{mod}}{{/str}}</small>{{/moodle4}}
                             {{#moodle3}}<small>{{#str}}modiconsuccess3x, theme_boost_union, {{mod}}{{/str}}</small>{{/moodle3}}
                         {{/invalidname}}
                         {{#invalidname}}
-                            <small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modiconactivityunknown, theme_boost_union{{/str}}</small><br />
+                            <small>{{#str}}modiconversion, theme_boost_union{{/str}}: {{#str}}modiconactivityunknown, theme_boost_union{{/str}}</small><br>
                             <small>{{#str}}modiconnamefail, theme_boost_union, {{mod}}{{/str}}</small>
                         {{/invalidname}}
                     {{/mod}}
                     {{^mod}}
-                        <small>{{#str}}modiconactivity, theme_boost_union{{/str}}: {{#str}}modiconactivityunknown, theme_boost_union{{/str}}</small><br />
+                        <small>{{#str}}modiconactivity, theme_boost_union{{/str}}: {{#str}}modiconactivityunknown, theme_boost_union{{/str}}</small><br>
                         <small>{{#str}}modiconnotexist, theme_boost_union, {{path}}{{/str}}</small>
                     {{/mod}}
                 </div>