Fix text centering for multi-line buttons including breaking long words. #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modification at lines 794 thru 824 fixes the issue of centering the text for the 2nd line of a button that has 2 lines of text. The modification at lines 595 thru 607 fixes the issue of breaking and centering a long word to fit on a 2 line button. This happens commonly with Japanese character strings, where the string contains no spaces.
|
@dotnet-policy-service agree company="Technotects, Inc." |
|
Hey, would you be willing to send this to https://gitlab.winehq.org/mono/libgdiplus ? |
|
Forwarded to https://gitlab.winehq.org/mono/libgdiplus/-/merge_requests/3 and merged there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modification at lines 794 thru 824 fixes the issue of centering the text for the 2nd line of a button that has 2 lines of text. The modification at lines 595 thru 607 fixes the issue of breaking and centering a long word to fit on a 2 line button. This happens commonly with Japanese character strings, where the string contains no spaces.