Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quickstart: assumes implicit knowledge of Makefile conventions #9

Open
lucab opened this issue Jun 15, 2020 · 7 comments
Open

quickstart: assumes implicit knowledge of Makefile conventions #9

lucab opened this issue Jun 15, 2020 · 7 comments

Comments

@lucab
Copy link

lucab commented Jun 15, 2020

First of all, thanks for the project and the docs!

Starting from no knowledge about monitoring mixins, I was trying to write some quick dashboarding mixin for a project of mine, by following the docs in this repo (as mirrored on https://monitoring.mixins.dev/).

I somehow got stuck on the step where it runs make. This assumes that the mixin-author already has a lot of knowledge about what they are supposed to do and what are the conventions around such Makefile.

I unfortunately had neither of those, so I was really tempted to just blindly copy the magic incantation from the first Makefile I could find (e.g. the node-exporter one).

I wasn't really convinced by that, and I ended up just running a minimal mixtool generate which seems to take care of the same logic.

For newcomers like me, it would be great to write down what is the interface for properly performing artifacts generations (and how to lay the mixins on disk so that generators are happy).

@brancz
Copy link
Member

brancz commented Jun 19, 2020

I think this is very good idea! Since you just went through it, do you think you could write up what you think you would have expected to see and contribute that? :)

@lucab
Copy link
Author

lucab commented Jul 1, 2020

For reference, I was starting from zero and trying to assemble this https://github.com/coreos/zincati/tree/v0.0.12/contrib/monitoring-mixins.

I ended up basically just using mixtool generate dashboards -d generated/dashboards/ mixin.libsonnet but it's unclear to me whether that tool is actually still maintained.

@brancz
Copy link
Member

brancz commented Jul 1, 2020

Yeah the tool hasn't really evolved in a while.

@metalmatze do you think we can maybe pick mixtool back up one of these days and discuss what it might look like going forward?

@metalmatze
Copy link

Was literally discussing this in the last week with @sh0rez.
Didn't see this thread until now. 🤔

Tom wants something like this for Tanka. I think there should be a standalone tool. So I'm happy to move forward with it.

@sh0rez
Copy link

sh0rez commented Jul 1, 2020

Indeed, working on a standalone tool! Will open source as soon as it kinda works :)

@metalmatze
Copy link

Couldn't we make this a continuation of this project rather than recreating with a new one?

@brancz
Copy link
Member

brancz commented Jul 1, 2020

I feel similar, why create something new? The mixtool exists ...? Anyways, would love to collaborate! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants