Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix #114

Merged
merged 5 commits into from
Oct 30, 2017
Merged

CI fix #114

merged 5 commits into from
Oct 30, 2017

Conversation

rtrv
Copy link
Collaborator

@rtrv rtrv commented Oct 27, 2017

  • Fix for Bundler fail #113
  • RSpec fails due to undefined ActiveSupport call
  • Passing Travis

TODOs:

  • Investigate and fix Mongoid 6.0 spec fails. Change Gemfile and travis.yml to support 6.0 after that
  • Resolve the problem with fast-stemmer native expensions with JRuby. Change travis.yml to check JRuby after that
  • Make sure the gem can run well with Rubinius. Change travis.yml to check Rubinius after that

@sveredyuk I suppose, these TODOs should be separated from this PR. I didn't found information about official JRuby and Rubinius support. And there is no info (or I don't see it) about Mongoid versions, which are supported. Currently there may be some problems with 6.0. Is there any statistics about usage mongoid_search with Mongoid 6?

@sveredyuk sveredyuk self-requested a review October 27, 2017 11:52
@sveredyuk sveredyuk self-assigned this Oct 27, 2017
@sveredyuk sveredyuk added the Bug label Oct 27, 2017
@rtrv rtrv mentioned this pull request Oct 27, 2017
@sveredyuk
Copy link
Collaborator

@rtrv Is it ready to merge? or still WIP ?

@rtrv rtrv changed the title [WIP] CI fix CI fix Oct 30, 2017
@rtrv
Copy link
Collaborator Author

rtrv commented Oct 30, 2017

@sveredyuk I've changed the name, it's ready. The problem with Mongoid 6.0 is in separate issue #115. And I'll create two issues for Rubinius and JRuby

@sveredyuk
Copy link
Collaborator

@rtrv Ok. thx a lot!

@sveredyuk sveredyuk merged commit 9ef5af7 into mongoid:master Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants