fix: add missing prometheus config to AutomationConfig #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielblanco96
approved these changes
Oct 17, 2024
|
I'm still testing out this latest version on my side this morning, will close this comment once I can confirm no issue was encountered |
|
@42esoulard thank you, feel free to merge it after that. I tested it myself and it looks good. After it gets merged I'll create a new version of the library. |
|
All good on my side, sorry about the slight delay. Looks like I do not have sufficient permissions to merge myself, can you proceed with the merge? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Current behaviour:
Prometheus configuration is missing from the AutomationConfig when we get it via the opsmngr GetConfig call. We can see it is missing from the AutomationConfig struct. However, prometheus configuration is present when we get it directly from the opsmanager API.
Proposed behaviour:
Prometheus configuration will be properly handled and returned in opsmngr GetConfig and UpdateConfig calls.
Checklist
make fmtand formatted my code