Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn that the buildpack is deprecated + no longer required #76

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

edmorley
Copy link
Contributor

This buildpack is no longer required now that the Heroku Python buildpack supports Poetry natively:

As such, a deprecation warning has been added to both the build log and the README.

The warning borrows from the implementation here (which uses colour, and also makes sure to ANSI wrap each line individually to prevent issues with streaming logs from git push etc):
https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66

Closes #75.

…ired

This buildpack is no longer required now that the Heroku Python
buildpack supports Poetry natively:
- https://devcenter.heroku.com/changelog-items/3050
- heroku/heroku-buildpack-python#1682

As such, a deprecation warning has been added to both the build
log and the README.

The warning borrows from the implementation here (which uses
colour, and also makes sure to ANSI wrap each line individually
to prevent issues with streaming logs from `git push` etc):
https://github.com/heroku/heroku-buildpack-python/blob/ca99c39f9e3627fff727788206f7fcc4ff064b7f/lib/output.sh#L50-L66

Closes moneymeets#75.
@edmorley edmorley force-pushed the deprecation-warning branch from ba49dd7 to 5b6496f Compare November 18, 2024 14:15
@edmorley
Copy link
Contributor Author

Example of the warning in the build log in the dashboard (showing the usage of colour):
Screenshot 2024-11-18 at 14 25 51

@marns93 marns93 requested review from felix11h and marns93 November 19, 2024 06:30
Copy link
Contributor

@felix11h felix11h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing these changes! 👍

Copy link
Contributor

@marns93 marns93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@marns93 marns93 merged commit 233075e into moneymeets:master Nov 19, 2024
4 checks passed
@edmorley edmorley deleted the deprecation-warning branch November 19, 2024 16:47
@edmorley
Copy link
Contributor Author

Thank you for the review and merge!

@edmorley
Copy link
Contributor Author

I don't suppose you own the moneymeets namespace on the Heroku Buildpack Registry? (Namespace names are independent of Heroku team names)

If so, would it be ok for you to push a new version there? :-)

$ heroku buildpacks:versions moneymeets/python-poetry
 Version Released At              Status
 ─────── ──────────────────────── ─────────
 2       2021-01-29T08:36:35.597Z published
 1       2020-12-27T22:10:28.531Z published

To save having to set up the Heroku CLI (and install the buildpack registry plugin) it's possible to trigger a publish from main of this repo via the UI here (if logged in as a user who is a member of the Heroku team connected to the registry namespace):
https://addons-next.heroku.com/buildpacks

@marns93
Copy link
Contributor

marns93 commented Nov 21, 2024

@edmorley Thanks for pointing to this. This was created by my account. I've published an updated version.

$ heroku buildpacks:versions moneymeets/python-poetry 
Version Released At              Status    
 ─────── ──────────────────────── ───────── 
 3       2024-11-21T12:57:43.849Z published 
 2       2021-01-29T08:36:35.597Z published 
 1       2020-12-27T22:10:28.531Z published 

This is not used, so in theory I could archive this. Same will be true for this repository, we will archive this in the next few days.

@edmorley
Copy link
Contributor Author

That sounds great! Thank you so much for both creating/maintaining this buildpack over the years and now helping with the transition :-)

@edmorley
Copy link
Contributor Author

This is not used, so in theory I could archive this.

Archiving is also a safe operation (the assets on S3 will remain, so existing apps using it will continue to build):
https://devcenter.heroku.com/articles/buildpack-registry#archiving-your-buildpack

Archiving a buildpack is a safe operation that will not break apps that currently use the buildpack.

@marns93
Copy link
Contributor

marns93 commented Nov 21, 2024

That sounds great! Thank you so much for both creating/maintaining this buildpack over the years and now helping with the transition :-)

It was our pleasure to create/maintain this buildpack and see the community using it.

@marns93
Copy link
Contributor

marns93 commented Nov 21, 2024

This is not used, so in theory I could archive this.

Archiving is also a safe operation (the assets on S3 will remain, so existing apps using it will continue to build): https://devcenter.heroku.com/articles/buildpack-registry#archiving-your-buildpack

Archiving a buildpack is a safe operation that will not break apps that currently use the buildpack.

Okay, if it is a safe operation there is absolutely nothing against archiving it. Archived already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate buildpack now that the Python buildpack supports Poetry
3 participants